Windows escape sequence fix #1674
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fixes #1594 |
|
✔️ Deploy Preview for devel-docs-dagger-io ready! 🔨 Explore the source changes: 5265591 🔍 Inspect the deploy log: https://app.netlify.com/sites/devel-docs-dagger-io/deploys/6228a6ae1da7b30008db6ea5 😎 Browse the preview: https://deploy-preview-1674--devel-docs-dagger-io.netlify.app |
|
Result: 100% compatibility |
aluzzardi
reviewed
Mar 9, 2022
Our logger wasn't entirely compatible with Windows escape sequences when not in TTY mode. This fix changes the stderr to one that automatically transforms the escape sequences to some Windows compatible ones. Signed-off-by: guillaume <guillaume.derouville@gmail.com>
|
Failing test seems to be unrelated Your comments are relevant. I rebased and applied them. It still fixes the issue, as expected: |
aluzzardi
approved these changes
Mar 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our logger wasn't entirely compatible with Windows escape sequences when not in TTY mode. This fix changes the stderr to a Windows compatible fd that automatically takes that into account.
Signed-off-by: guillaume guillaume.derouville@gmail.com