8000 Fix unsaved in progress reports by iSevenDays · Pull Request #605 · danielpaulus/go-ios · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix unsaved in progress reports #605

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 18, 2025
Merged

Fix unsaved in progress reports #605

merged 3 commits into from
Jun 18, 2025

Conversation

iSevenDays
Copy link
Contributor

The PR fixes saving of in-progress tests reports that are interrupted when test runner is killed due to numerous reasons such as misuse of assertions in the unit test code.
With this PR, the report will preserver the important information about the test suite test results and provide an error line where the issue happens.

Before the fix

{"level":"info","msg":"Killing test runner with pid 948 ...","time":"2025-06-18T13:25:39+02:00"}
{"level":"info","msg":"Killing test runner with pid 948 ...","time":"2025-06-18T13:25:39+02:00"}
{"level":"info","msg":"Nothing to kill, process with pid 948 is already dead","time":"2025-06-18T13:25:39+02:00"}
{"level":"debug","msg":"Done running test","time":"2025-06-18T13:25:39+02:00"}
{"level":"debug","msg":"DTX Connection with EOF","time":"2025-06-18T13:25:39+02:00"}
{"error":"lost connection to testmanagerd. the test-runner may have been killed","level":"info","msg":"Failed running Xcuitest","time":"2025-06-18T13:25:39+02:00"}
[]{"level":"info","msg":"2 \u003cnil\u003e","time":"2025-06-18T13:25:39+02:00"}
Exiting.
2025-06-18T13:25:39+02:00 debug layer=debugger detaching

after the fix

{"error":"lost connection to testmanagerd. the test-runner may have been killed","level":"info","msg":"Failed running Xcuitest","time":"2025-06-17T20:17:16+02:00"}
[{Name:GeneralTest StartDate:2025-06-17 18:16:44 +0000 UTC EndDate:0001-01-01 00:00:00 +0000 UTC TestDuration:0s TotalDuration:0s TestCases:[{ClassName:GeneralTest MethodName
8000
:testDeleteSignOut Status:failed Err:{Message:XCTAssertTrue failed - Resections button is not tappable after 120 seconds File:file:///Users/user/Documents/GitHub/app/myUITests/PageObjects/MyCasesPage.swift Line:1144} Duration:0s Attachments:[{Name:App UI hierarchy for com.test.MakoApp Path:/var/folders/q2/pmncxy_n5vq0s_9tzz7j8nq40000gn/T/b6f55992-c5e8-4de4-b76f-b48f9cd6c01f Type:com.apple.dt.xctest.activity-type.internal Timestamp:7.71877016952447e+08 Activity:Collecting debug information to assist test failure triage UniformTypeIdentifier:public.plain-text}]}]}]{"level":"info","msg":"782 \u003cnil\u003e","time":"2025-06-17T20:17:16+02:00"}
Exiting.
2025-06-17T20:17:16+02:00 debug layer=debugger detaching

@iSevenDays iSevenDays mentioned this pull request Jun 18, 2025
Merged
@dmissmann dmissmann merged commit c125138 into danielpaulus:main Jun 18, 2025
2 checks passed
@iSevenDays iSevenDays deleted the fix-unsaved-in-progress-reports branch June 18, 2025 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmissmann dmissmann dmissmann approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@iSevenDays @dmissmann
0