chore: update dependencies #699
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bbf0b47 to
039bf97
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #699 +/- ##
============================================
- Coverage 100.00% 54.84% -45.16%
============================================
Files 1 14 +13
Lines 6 330 +324
Branches 1 66 +65
============================================
+ Hits 6 181 +175
- Misses 0 131 +131
- Partials 0 18 +18 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
2845501 to
6f9a3ec
Compare
Signed-off-by: Joe Bowbeer <joe.bowbeer@gmail.com>
6f9a3ec to
6ac46d5
Compare
WhitWaldo
approved these changes
May 27, 2025
joebowbeer
added a commit
to joebowbeer/dapr-js-sdk
that referenced
this pull request
May 27, 2025
Signed-off-by: Joe Bowbeer <joe.bowbeer@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
1️⃣ Testing
All modified and coverable lines are covered by tests. (The only code that changed is a test.)
All tests pass, once a flaky e2e test was fixed:
Rationale for change: The important thing to test is that the counter doesn't change after the reminder is unregistered. The exact counter value is not important in this test.
2️⃣ Codecov
Why is codecov complaining even though the only code changed was a test?
Is this a byproduct of upgrading the codecov action from v1 to v5?
3️⃣ Added lines
All of the added lines are coming from typescript-build's updated package-lock.json
Issue reference
We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.
Please reference the issue this PR will close: #698
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: