8000 Module presets not applying after upgrade 4.8 to 5.0 · Issue #18184 · darktable-org/darktable · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Module presets not applying after upgrade 4.8 to 5.0 #18184

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
8000
mprichards opened this issue Jan 10, 2025 · 16 comments
Open

Module presets not applying after upgrade 4.8 to 5.0 #18184

mprichards opened this issue Jan 10, 2025 · 16 comments
Labels
no-issue-activity

Comments

@mprichards
Copy link

Describe the bug

None of the presets on modules work when selecting them from the hamburger menu. I have tried creating my own preset and these do not work either. Were working fine prior to upgrade.

Steps to reproduce

  1. Open image in darkroom
  2. Select module preset (eg diffuse or sharpen: sharpness)
  3. Module stays inactive, no changes applied

Expected behavior

Presets should activate module with expected values

Logfile | Screenshot | Screencast

No response

Commit

No response

Where did you obtain darktable from?

downloaded from www.darktable.org

darktable version

5.0.0

What OS are you using?

Windows

What is the version of your OS?

Windows 11 Pro

Describe your system?

No response

Are you using OpenCL GPU in darktable?

Yes

If yes, what is the GPU card and driver?

NVIDIA GeForce GTX 1050 Ti

Please provide additional context if applicable. You can attach files too, but might need to rename to .txt or .zip

No response
@MStraeten
Copy link
Collaborator

did you also try it with a clean darktable-config directory?
e.g. by starting via commandline: <wherever your darktable binary is>darktable.exe --configdir <a temporary location>

@mprichards
Copy link
Author

Yes, running with new config location doesn't work either.

@TurboGit
Copy link
Member

Something corrupted on your side, this would have been already reported as a huge regression and quite visible. I have no idea about the possible issue though.

@mprichards
Copy link
Author

Indeed, I was expecting to see that someone else had already logged an issue.

I've just installed 5.0 to a new location and renamed the original config dir in AppData and still does the same thing. When reinstalling it still thought darktable was already installed - are there any additional locations that need to be cleaned?

@MStraeten
Copy link
Collaborator

then it's time to get log files: see https://www.darktable.org/about/faq/#faq-windows-bugs

@mprichards
Copy link
Author
mprichards commented Jan 10, 2025 •
edited
Loading

darktable-log.txt
This is the log from running with -d common - launched and tried to apply a couple of presets.

Repeated with -d all:
darktable-log-alldebug.txt

Let me know if there's anything else that would help.

@mprichards
Copy link
Author

Also just tried with -d verbose as well, and it crashed on start:
darktable-log-alldebug-verbose.txt

@ghwaldo
Copy link
ghwaldo commented Jan 10, 2025

Same Problem here WIN 10 after Upgrade to 5.0.
I've renamed the old darktable folder under appdata, but still presets of the modules are not applied.

@ghwaldo
Copy link
ghwaldo commented Jan 10, 2025 •
edited
Loading

No errors in any log-files

I can enable the module, for example, tone eq, but clicking on any preset does simply nothing.
I can use the module when i manually set values, but no preset is setting any values in

  • tone eq
  • colour balance
  • local contrast
  • contrast eq ...

@mprichards
Copy link
Author

Just browsing through some of the commits that might be related and was looking at 4676fec#diff-02bcf1785397fb026217b2580c2e764e9f3420ab5cf3d3e6d5e00342d810831eR2970

I don't know GTK, but it made me wonder if some of the events are mapped differently in Windows, so I tested using right-click. Presets are applied if I click the item using a right-click rather than a left-click!

@europlatus
Copy link

Just posting to say that I recently had this issue of not being able to apply presets. I'm on Windows 10 and running 5.0.0.
Restarting Darktable did not fix the issue, but restarting my PC did. I'm monitoring to see if I can reproduce it.

@jenshannoschwalm jenshannoschwalm mentioned this issue Jan 15, 2025
Open
@github-actions GitHub Actions
Copy link

This issue has been marked as stale due to inactivity for the last 60 days. It will be automatically closed in 300 days if no update occurs. Please check if the master branch has fixed it and report again or close the issue.

@delan
Copy link
delan commented Mar 17, 2025 •
edited
Loading

I am seeing this too on darktable 5.0.1, with different behaviour depending on the module:

  • lens correction — existing presets still listed, automatically apply, and can be manually applied
  • denoise (profiled) — existing presets still listed, automatically apply, and can be manually applied
  • export — existing presets disappeared, store new preset does nothing when clicked
  • haze removal — store new preset opens dialog when clicked, ok closes dialog but does nothing

Interesting terminal output on startup:

sqlite3 error: /build/darktable-5.0.1/src/gui/presets.c:89, function dt_gui_presets_init(), query "DELETE FROM data.presets WHERE writeprotect = 1": attempt to write a readonly database
     0.8477 [imageop_init_presets] updating 'dither' preset 'dither' from version 1 to version 2
to:'05000000000000000000000000000000000000000000803f0000803f000048c3'
     1.0504 [lighttable_init_presets] updating 'export' preset '3000' from version 7 to version 8
     1.0505 [lighttable_init_presets] updating 'export' preset '675' from version 7 to version 8
     1.0505 [lighttable_init_presets] updating 'export' preset '606' from version 7 to version 8
     1.0505 [lighttable_init_presets] updating 'export' preset 'original' from version 7 to version 8
     1.0505 [export_init_presets] found export preset '3000' with version 7, version 8 was expected. dropping preset
     1.0506 [export_init_presets] found export preset '675' with version 7, version 8 was expected. dropping preset
     1.0506 [export_init_presets] found export preset '606' with version 7, version 8 was expected. dropping preset
     1.0506 [export_init_presets] found export preset 'original' with version 7, version 8 was expected. dropping preset
     1.0651 [lighttable_init_presets] updating 'metadata' preset 'CC BY' from version 3 to version 4
     1.0651 [lighttable_init_presets] updating 'metadata' preset 'CC BY-SA' from version 3 to version 4
     1.0651 [lighttable_init_presets] updating 'metadata' preset 'CC BY-ND' from version 3 to version 4
     1.0651 [lighttable_init_presets] updating 'metadata' preset 'CC BY-NC' from version 3 to version 4
     1.0651 [lighttable_init_presets] updating 'metadata' preset 'CC BY-NC-SA' from version 3 to version 4
     1.0651 [lighttable_init_presets] updating 'metadata' preset 'CC BY-NC-ND' from version 3 to version 4
     1.0651 [lighttable_init_presets] updating 'metadata' preset 'all rights reserved' from version 3 to version 4
sqlite3 error: /build/darktable-5.0.1/src/libs/modulegroups.c:1325, function _preset_retrieve_old_presets(), query "DELETE FROM data.presets WHERE operation = 'modulelist' AND op_version = 1": attempt to write a readonly database

@parafin
Copy link
Member
parafin commented Mar 17, 2025

Your database is read-only (probably permissions problem on the file).

@delan
Copy link
delan commented Mar 17, 2025

Yeah, it seems it somehow ended up read-only after I upgraded:

$ ls -l ~/.config/darktable/*.db{,-pre-*}
-r-------- 1 delan users   356352 Feb  1 09:42 /home/delan/.config/darktable/data.db
-r-------- 1 delan users        0 Jun  7  2024 /home/delan/.config/darktable/data.db-pre-4.4.2
-r-------- 1 delan users   315392 Jul 14  2024 /home/delan/.config/darktable/data.db-pre-4.6.1
-r-------- 1 delan users   319488 Sep  8  2024 /home/delan/.config/darktable/data.db-pre-4.8.1
-r-------- 1 delan users   356352 Feb  1 09:42 /home/delan/.config/darktable/data.db-pre-5.0.1
-rw------- 1 delan users 67469312 Mar 17 17:26 /home/delan/.config/darktable/library.db
-r-------- 1 delan users        0 Jun  7  2024 /home/delan/.config/darktable/library.db-pre-4.4.2
-r-------- 1 delan users  9011200 Jul 14  2024 /home/delan/.config/darktable/library.db-pre-4.6.1
-r-------- 1 delan users 25690112 Sep  8  2024 /home/delan/.config/darktable/library.db-pre-4.8.1
-rw------- 1 delan users 64552960 Feb 16 22:56 /home/delan/.config/darktable/library.db-pre-5.0.1

Fixing the permissions on data.db fixed all of these problems:

$ chmod u+w ~/.config/darktable/data.db
$ ls -l ~/.config/darktable/data.db
-rw------- 1 delan users 356352 Feb  1 09:42 /home/delan/.config/darktable/data.db
$ darktable
[...]
     8.2672 [lighttable_init_presets] updating 'export' preset '3000' from version 7 to version 8
     8.2692 [lighttable_init_presets] updating 'export' preset '675' from version 7 to version 8
     8.2711 [lighttable_init_presets] updating 'export' preset '606' from version 7 to version 8
     8.2729 [lighttable_init_presets] updating 'export' preset 'original' from version 7 to version 8

@github-actions GitHub Actions
Copy link

This issue has been marked as stale due to inactivity for the last 60 days. It will be automatically closed in 300 days if no update occurs. Please check if the master branch has fixed it and report again or close the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
no-issue-activity
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
8 participants
@delan @TurboGit @parafin @mprichards @MStraeten @ghwaldo @europlatus and others
0