-
Notifications
You must be signed in to change notification settings - Fork 1.2k
DT doesn't apply presets when clicked #18214
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
* kivi4983 ***@***.***> [01-01-70 12:34]:
### Describe the bug
While editing in darkroom, when trying to apply a preset for a module in the preset dropdown, upon clicking the wanted preset, nothing happens.
### Steps to reproduce
1. Open any image in darkroom
2. Open any module with presets
3. Open the preset dropdown
4. Click on a preset
### Expected behavior
Apply the preset to the module
confirmed on openSUSE Tumbleweed self compiled master 5.1.0+68~g57cc85c4a6
…--
(paka)Patrick Shanahan Plainfield, Indiana, USA @ptilopteri
facebook/ptilopteri
Photos: http://wahoo.no-ip.org/piwigo paka @ IRCnet oftc
|
can't reproduce on Ubuntu 22.04, darktable 5.1.0+67~gc1a11e7090 EDIT: I tried user defined and supplied presets (i.e. diffuse or sharpen AA sharpen). |
Can't reproduce and I'm using presets all the time, this is a regression I have never ever experienced. So we need some more context to reproduce. |
@ptilopteri @kivi4983 can you confirm that a right-click works - adding a new instance of that module? |
Not able to reproduce on master under windows and debian. 5.0 has issues in this area (although I didn't see this issue), so updating to a nightly might help. @ptilopteri could you try pressing-and-holding the mouse button on the preset button, "dragging" down to the preset and then releasing? Can you select a preset using the arrow keys and enter? The fix for the 5.0 bug involved ignoring clicks until the mouse has been moved over the menu. Could you check if the callback |
* Hanno Schwalm ***@***.***> [01-14-25 22:34]:
@ptilopteri @kivi4983 can you confirm that a right-click works - adding a new instance of that module?
duplicate of #18184
I can no long recreate. 5.1.0+68~g57cc85c4a6
…--
(paka)Patrick Shanahan Plainfield, Indiana, USA @ptilopteri
facebook/ptilopteri
Photos: http://wahoo.no-ip.org/piwigo paka @ IRCnet oftc
|
* dterrahe ***@***.***> [01-15-25 07:40]:
Not able to reproduce on master under windows and debian.
5.0 has issues in this area (although I didn't see _this_ issue), so updating to a nightly _might_ help.
@ptilopteri could you try pressing-and-holding the mouse button on the preset button, "dragging" down to the preset and then releasing? Can you select a preset using the arrow keys and enter?
The fix for the 5.0 bug involved ignoring clicks until the mouse has been moved over the menu. Could you check if the callback `_menuitem_motion_preset` (in `gui\presets.c`) gets triggered? (by putting `dt_print(0, "test motion callback");` as the first line and starting from a shell)
I can no longer recreate, 5.1.0+68~g57cc85c4a6
…--
(paka)Patrick Shanahan Plainfield, Indiana, USA @ptilopteri
facebook/ptilopteri
Photos: http://wahoo.no-ip.org/piwigo paka @ IRCnet oftc
|
From @europlatus #18184
Don't know how windows builds set up gtk. Could this be the issue? |
I have the same issue. Darktable 5.0.0 OpenCL GPU: I think yes (it's enabled in the settings at least) |
Windows builds use the same build script that other builds do. Building runs under the msys2 environment. |
This issue has been marked as stale due to inactivity for the last 60 days. It will be automatically closed in 300 days if no update occurs. Please check if the master branch has fixed it and report again or close the issue. |
Uh oh!
There was an error while loading. Please reload this page.
Describe the bug
While editing in darkroom, when trying to apply a preset for a module in the preset dropdown, upon clicking the wanted preset, nothing happens.
Steps to reproduce
Expected behavior
Apply the preset to the module
Right clicking however successfully creates a duplicate with the preset applied.
Logfile | Screenshot | Screencast
Commit
No response
Where did you obtain darktable from?
downloaded from www.darktable.org
darktable version
5.0.0
What OS are you using?
Windows
What is the version of your OS?
Windows 11 Pro
Describe your system?
Socket 1 ID = 0
Number of cores 8 (max 8)
Number of threads 16 (max 16)
Secondary bus # 0
Number of CCDs 1
Manufacturer AuthenticAMD
Name AMD Ryzen 7 5700X3D
Chipset
Northbridge AMD Ryzen SOC rev. 00
Southbridge AMD B550 rev. 51
Bus Specification PCI-Express 4.0 (16.0 GT/s)
Graphic Interface PCI-Express 4.0
PCI-E Link Width x16 (max 16x)
PCI-E Link Speed 16.0 GT/s (max 16.0 GT/s)
Memory Type DDR4
Memory Size 32 GBytes
Channels 2 x 64-bit
Memory Frequency 1066.3 MHz (3:32)
Memory Max Frequency 1600.0 MHz
CAS# latency (CL) 15.0
RAS# to CAS# delay (tRCD) 15
RAS# Precharge (tRP) 15
Cycle Time (tRAS) 36
Bank Cycle Time (tRC) 51
Command Rate (CR) 2T
Uncore Frequency 1066.3 MHz
Display adapter 0 (primary)
ID 0x2170003
Name AMD Radeon RX 6750 XT
Board Manufacturer XFX Limited
Monitor 0
Model DELL U2414H (Dell Computer)
Max Resolution 1920 x 1080 @ 60 Hz
Are you using OpenCL GPU in darktable?
I dont know
If yes, what is the GPU card and driver?
No response
Please provide additional context if applicable. You can attach files too, but might need to rename to .txt or .zip
The issue persists after a restart/reinstall.
It is independent of the file edited (raw/jpg), it seems to be a UI issue.
"Are the steps above reproducible with a fresh edit (i.e. after discarding history)?" yes
"Is the issue still present using an empty/new config-dir (e.g. start darktable with --configdir "/tmp")?" yes
"Can you reproduce with another darktable version(s)? yes with version x-y-z" no, 4.8.1 this works fine
I dont use lua scripts
The text was updated successfully, but these errors were encountered: