8000 Better calculation of cropped UI output dimension by jenshannoschwalm · Pull Request #18785 · darktable-org/darktable · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Better calculation of cropped UI output dimension #18785

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 10, 2025
Merged

Better calculation of cropped UI output dimension #18785

merged 2 commits into from
May 10, 2025

Conversation

jenshannoschwalm
Copy link
Collaborator

While setting the crops we get a feedback about it's resulting width & height.

In modify_roi_out() and modify_roi_in() the position and width are set to the floored values to guarantee we stay inside available data range.

Let's report the floored value in expose instead of what we did, also via -d verbose log.

Related to #18781

Also see #18784

@jenshannoschwalm
dt_dev_get_processed_size() returns a gboolean
f8582cc 
In some cases we would like to know if the reported dimensions are from current port/pipe
of rounded from preview pipe data.
@jenshannoschwalm
Better calculation of cropped output dimension
2b703e7 
While setting the crops we get a feedback about it's resulting width & height.

In modify_roi_out() and modify_roi_in() the position and width are set to the floored values
to guarantee we stay inside available data range.

Let's report the floored value in expose instead of what we did, also via -d verbose log.
@jenshannoschwalm jenshannoschwalm mentioned this pull request May 10, 2025
Closed
@TurboGit TurboGit added this to the 5.2 milestone May 10, 2025
@TurboGit TurboGit added the scope: codebase making darktable source code easier to manage label May 10, 2025
TurboGit
TurboGit approved these changes May 10, 2025
View reviewed changes
Copy link
Member
@TurboGit TurboGit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@TurboGit TurboGit merged commit d6cdf1c into darktable-org:master May 10, 2025
6 checks passed
@jenshannoschwalm jenshannoschwalm deleted the crop_expose_dimension branch May 10, 2025 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TurboGit TurboGit TurboGit approved these changes

Assignees
No one assigned
Labels
scope: codebase making darktable source code easier to manage
Projects
None yet
Milestone
5.2
Development

Successfully merging this pull request may close these issues.
2 participants
@jenshannoschwalm @TurboGit
0