8000 add apply_sidecar function to dt_lua_image_t by wpferguson · Pull Request #18792 · darktable-org/darktable · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

add apply_sidecar function to dt_lua_image_t #18792

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 13, 2025
Merged

add apply_sidecar function to dt_lua_image_t #18792

merged 1 commit into from
May 13, 2025

Conversation

wpferguson
Copy link
Member

apply_sidecar allows a sidecar file to be applied from a Lua script.

Fixes #16599.

Bumped API version to 9.5.0

Added Lua section to RELEASE_NOTES.md

@wpferguson
lua/image.c - added apply_sidecar function to apply an XMP file
a1067bc 
              to an image in lighttable.

lua/configuration.h - bumped API to 9.5.0

RELEASE_NOTES.md - updated lua section
@wpferguson wpferguson added feature: enhancement current features to improve lua labels May 11, 2025
@wpferguson
Copy link
Member Author

Here's a script to test with

apply_sidecar.zip

Unzip it into your scripts. Edit the file and replace "<put xmp path here>" with the path to a sidecar file. Assign a keyboard shortcut, then select an image and use the shortcut to apply the XMP file.

@TurboGit
Copy link
Member

@wpferguson : Testes and don't work on my side. The lua script is visible, I have activated it and assigned a shortcut, changed the path to a proper XMP... But when I hit the key nothing happens, not even an error in the console. Am I missing something ?

@wpferguson
Copy link
Member Author

Did you give the full path to the XMP? That's the only thing I can think of. If that's not it, I'll add some debug comments to the script and then we can see what it tells us.

@TurboGit
Copy link
Member

Did you give the full path to the XMP? That's the only thing I can think of. If that's not it, I'll add some debug comments to the script and then we can see what it tells us.

Yes, I put the full pathname but with a typo in my name :) How embarrassing :) Sorry for the noise. All working now.

@TurboGit TurboGit added this to the 5.2 milestone May 13, 2025
TurboGit
TurboGit approved these changes May 13, 2025
View reviewed changes
Copy link
Member
@TurboGit TurboGit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@TurboGit TurboGit merged commit 83c1a54 into darktable-org:master May 13, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TurboGit TurboGit TurboGit approved these changes

Assignees
No one assigned
Labels
feature: enhancement current features to improve lua
Projects
None yet
Milestone
5.2
Development

Successfully merging this pull request may close these issues.

FR: LUA API: add load_sicecar for dt_lua_image_t or make dt_lua_image_t.sidecar writeable
2 participants
@wpferguson @TurboGit
0