Fix two importing issues #18134
Merged
Fix two importing issues #18134
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We ask for dng files with specific exif tags that are currently not supported in darktable. As some software (like from adobe) possibly adds those tags we get warnings for such images, but - we simply don't care about those as we want data from camera vendor - that gives irrelevant feedback to user - it spoils the database with tags So if we find some non-dng name in "Exif.Image.OriginalRawFileName" we ignore those images for backreporting.
As we currently do in _import_enum_callback() the G_IO_ERROR_CANCELLED condition is not a real error and should not be reported as such.
|
Merged in master and darktable-5.0.x branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only ask for original dng files via github
We ask for dng files with specific exif tags that are currently not supported in darktable.
As some software (like from adobe) possibly adds those tags we get warnings for such images, but
So if we find some non-dng name in "Exif.Image.OriginalRawFileName" we ignore those images for backreporting.
Fixes #18109
Don't report G_IO_ERROR_CANCELLED in
_import_add_file_callback()As we currently do in
_import_enum_callback()the G_IO_ERROR_CANCELLED condition is not a real error and should not be reported as such.