10000 Rawoverexposed CL fix and maintenance by jenshannoschwalm · Pull Request #19035 · darktable-org/darktable · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Rawoverexposed CL fix and maintenance #19035

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 5, 2025
Merged

Rawoverexposed CL fix and maintenance #19035

merged 1 commit into from
Jul 5, 2025

Conversation

jenshannoschwalm
Copy link
Collaborator
  1. Make sure we have a correct error code and add a missed check.
  2. Use better CLFLARRAY #define where appropriate
  3. Avoid vstore4 as it's depending on vendor lib and not faster than explecite test & set to zero
  4. Make sure we never feed NaN or negs to the pipe in related kernels

Related to #19032

8000
@jenshannoschwalm
Copy link
Collaborator Author 
In file included from /Users/runner/work/darktable/darktable/src/src/imageio/imageio_heif.c:21:
In file included from /usr/local/include/libheif/heif.h:26:
/usr/local/include/libheif/heif_image.h:107:34: fatal error: redefinition of typedef 'heif_image_handle' is a C11 feature [-Wtypedef-redefinition]
typedef struct heif_image_handle heif_image_handle;
                                 ^
/usr/local/include/libheif/heif_library.h:95:34: note: previous definition is here
typedef struct heif_image_handle heif_image_handle;

Don't know what to make out of this ...

@victoryforce
Copy link
Collaborator

This is purely a libhef issue, so the simplest countermeasure would be to silence this warning (I'll do a PR).

I don't think we should bump to C11 just to fix this problem. Whether it makes sense regardless of this is another question.

@jenshannoschwalm jenshannoschwalm force-pushed the rawoverexpose_intelcl branch from 55e310a to af5e771 Compare July 3, 2025 15:45
@jenshannoschwalm
Rawoverexposed CL fix and maintenance
ec296d3 
1. Make sure we have a correct error code and add a missed check.
2. Use better CLFLARRAY #define where appropriate
3. Avoid vstore4 as it's depending on vendor lib and not faster than explicite test & set to zero
4. Make sure we never feed NaN or negs to the pipe in related kernels
5. use float4 array for simplicity
6. Make use of dt_opencl_copy_host_to_device_constant
@jenshannoschwalm jenshannoschwalm force-pushed the rawoverexpose_intelcl branch from af5e771 to ec296d3 Compare July 3, 2025 16:05
@zisoft zisoft mentioned this pull request Jul 4, 2025
Open
@TurboGit TurboGit added this to the 5.2.1 milestone Jul 5, 2025
TurboGit
TurboGit approved these changes Jul 5, 2025
View reviewed changes
Copy link
Member
@TurboGit TurboGit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@TurboGit TurboGit added the bugfix pull request fixing a bug label Jul 5, 2025
@TurboGit TurboGit merged commit b67d715 into darktable-org:master Jul 5, 2025
5 of 6 checks passed
@TurboGit
Copy link
Member
TurboGit commented Jul 5, 2025

Merged in master and 5.2.x branch.

@jenshannoschwalm jenshannoschwalm deleted the rawoverexpose_intelcl branch July 6, 2025 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TurboGit TurboGit TurboGit approved these changes

Assignees
No one assigned
Labels
bugfix pull request fixing a bug
Projects
None yet
Milestone
5.2.1
Development

Successfully merging this pull request may close these issues.
3 participants
@jenshannoschwalm @victoryforce @TurboGit
0