8000 Fix liquify OpenCL code by jenshannoschwalm · Pull Request #19070 · darktable-org/darktable · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix liquify OpenCL code #19070

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 14, 2025
Merged

Fix liquify OpenCL code #19070

merged 1 commit into from
Jul 14, 2025
+11 −13

Conversation

jenshannoschwalm
Copy link
Collaborator
  1. Don't clamp liquify mixed output but just make sure we have non-negative output as we have in cpu code.
  2. Make sure we can't have div-by-zero
  3. the internal interpolators should behave as cpu dt_interpolation_compute_pixel4c() ensuring non-negative input signals.

Fixes #19057

@TurboGit bugfix for master and 5.2.1

Release note: Fixed a bug in liquify OpenCL code leading to incorrect clamped output.

@jenshannoschwalm
Fix liquify OpenCL code
94ef041 
1. Don't clamp liquify mixed output but just make sure we have non-negative output as we have in cpu code.
2. Make sure we can't have div-by-zero
3. the internal interpolators should behave as cpu dt_interpolation_compute_pixel4c() ensuring non-negative input signals.
@jenshannoschwalm jenshannoschwalm added bugfix pull request fixing a bug priority: high core features are broken and not usable at all, software crashes scope: image processing correcting pixels OpenCL Related to darktable OpenCL code labels Jul 12, 2025
@jenshannoschwalm jenshannoschwalm added this to the 5.2.1 milestone Jul 12, 2025
TurboGit
TurboGit approved these changes Jul 14, 2025
View reviewed changes
Copy link
Member
@TurboGit TurboGit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@TurboGit TurboGit merged commit 872e4b8 into darktable-org:master Jul 14, 2025
6 checks passed
@TurboGit
Copy link
Member

Merged in master & darktable-5.2.x branch.

@jenshannoschwalm jenshannoschwalm deleted the fix_liquify_opencl branch July 14, 2025 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TurboGit TurboGit TurboGit approved these changes

Assignees
No one assigned
Labels
bugfix pull request fixing a bug OpenCL Related to darktable OpenCL code priority: high core features are broken and not usable at all, software crashes scope: image processing correcting pixels
Projects
None yet
Milestone
5.2.1
Development

Successfully merging this pull request may close these issues.

Liquify produces a desaturation
2 participants
@jenshannoschwalm @TurboGit
0