8000 degrees <-> radians conversion clean-up by kofa73 · Pull Request #19077 · darktable-org/darktable · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

degrees <-> radians conversion clean-up #19077

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 28 commits into
base: master
Choose a base branch
from
Open

degrees <-> radians conversion clean-up #19077

wants to merge 28 commits into from

Conversation

kofa73
Copy link
Contributor
@kofa73 kofa73 commented Jul 13, 2025

Standardising degrees <-> radians conversions, as requested:
#19026 (comment)

kofa73
kofa73 commented Jul 13, 2025
View reviewed changes
kofa73 added 27 commits July 13, 2025 14:35
@kofa73
Added degrees <-> radians conversion functions to common/math.h
bfecb8e
@kofa73
Updated conversions in dtgtk/paint.c
9d51e4d
@kofa73
Updated conversions in chart/deltaE.c
7a40658
@kofa73
Updated conversions in common/gpx.c
22850e6
@kofa73
Replaced pi with M_PI_F in chart/thinplate.c
12ff2db
@kofa73
Replaced conversions in develop/masks/ellipse.c
ce2fbfe
@kofa73
Replaced conversions in develop/masks/gradient.c
27d42d1
@kofa73
Added conversion factors to common/math.h
8748e24
@kofa73
Minor conversion changes in iop/sigmoid.c
05f91ba
@kofa73
Minor conversion change in develop/lightroom.c
5128f16
@kofa73
Minor conversion change in iop/primaries.c
99178b6
@kofa73
Minor conversion change in iop/overlay.c
d0d446a
@kofa73
Conversion and related changes in iop/graduatednd.c
4c6ff63
@kofa73
Restored '3.145 / 180' conversions in paint.c, looks intentional.
119ea9d
@kofa73
Updated conversions on iop/ashift.c
2881c3c
@kofa73
Updated conversions on gui/guides.c
a65c8bb
@kofa73
Updated conversions on iop/ashift_lsd.c
a5352f4
@kofa73
Updated conversions on iop/blurs.c
907edaa
@kofa73
Updated conversions in gui/gtk.c
aaeaf8a
@kofa73
Made new constant + functions static in common/math.h
f93ff7b
@kofa73
Restoring imports in gui/gtk.c (OSX build fails)
6affd97
@kofa73
Updated conversions in iop/channelmixerrgb.c
429a512
@kofa73
Updated conversions in iop/clipping.c
0dde38e
@kofa73
Updated conversions in iop/colorbalancergb.c
a84976b 
v1 parameter conversion is suspect, saturation is unlikely to be an angle: n->saturation_global = deg2radf(n->saturation_global);
@kofa73
Updated conversions in libs/histogram.c
56f565e
@kofa73
Updated the rest of the conversions
a13cb82
@kofa73
Copyright year updates
3ce1a82
@kofa73 kofa73 changed the title Draft: degrees <-> radians conversion clean-up degrees <-> radians conversion clean-up Jul 13, 2025
@kofa73 kofa73 marked this pull request as ready for review July 13, 2025 12:48
@TurboGit TurboGit added this to the 5.4 milestone Jul 13, 2025
@TurboGit TurboGit added the scope: codebase making darktable source code easier to manage label Jul 13, 2025
@jenshannoschwalm
Copy link
Collaborator

Very nice cleanup 👍

@da-phil
Copy link
Contributor
da-phil commented Jul 14, 2025

Indeed, very nice refactoring, thanks for that 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TurboGit TurboGit TurboGit left review comments

Assignees
No one assigned
Labels
scope: codebase making darktable source code easier to manage
Projects
None yet
Milestone
5.4
Development

Successfully merging this pull request may close these issues.
4 participants
@kofa73 @jenshannoschwalm @da-phil @TurboGit
0