Add support for spot removal presets. #399
Conversation
|
But after all the drawn masks are not saved with the presets in all modules, so is this really good? I mean the fix here if working should probably be seen as a temporary solution. The proper fix would be to be able to save the masks with the presets and with the styles. Is there a consensus about this? |
|
what does this PR needs ? discussion ? you might want to send a mail to the ML in that case... is it still up for merge ? |
|
Yes some more discussion. I think the proper solution may be to be able to save also the drawn masks with the presets. Not sure if this is easy or even feasible actually. So as I said my patch here is ok and should be merged only if we agreed that having the masks saved with the presets is not desirable. I'd like some more feedback. |
|
IIUC you copy the mask from an image to another image, this is not good because it dont' work if the image is removed. I am not sure if it's fine to save the mask in preset. I don't really see why not, but otoh I don't really see the point of saving masks and spots in the preset. timelapse and focus stacking ? I'll try to get people from IRC to comment here |
|
Hi all, |
|
Old and abandoned, closing. |
Here is a fix for having the spot removal presets working.
Please review carefully, I'm not sure it is the best way to fix this but I did not found a better solution. At least this patch set is relatively small.