8000 Color picker and distorting modules doc change by Phemisters · Pull Request #757 · darktable-org/dtdocs · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Color picker and distorting modules doc change #757

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

Phemisters
Copy link
Contributor

darktable PR: darktable-org/darktable#16534

I have copied the text from the release description since (after trying it out) I couldn't come up with a better way of describing this change. In fact, it may be that we don't need to add the extra text at all, as I suppose it now works the way people might have assumed it worked anyway.

I also fixed what seem to be broken references to the icon.

@elstoc
Copy link
Contributor
elstoc commented Apr 17, 2025

The bit about the icon was supposed to be a link to the section of the manual that describes pickers (in general), rather than an icon (I assume that link does work). Also I think that extra sentence poses more questions (to the user) than it answers.

So I don't think we need this PR, though I'm open to discussion if you disagree.

@Phemisters
Copy link
Contributor Author

The bit about the icon was supposed to be a link to the section of the manual that describes pickers (in general), rather than an icon (I assume that link does work).

For me the existing link results in a 404 response, and it is not clear to me what the intention is if its not the icon.

So I don't think we need this PR, though I'm open to discussion if you disagree.

I'm happy to close the PR.

@Phemisters Phemisters closed this Apr 17, 2025
@elstoc
Copy link
Contributor
elstoc commented Apr 17, 2025

For me the existing link results in a 404 response, and it is not clear to me what the intention is if its not the icon.

Yes you're right, the link is broken. Fixed in ff09e60

@Phemisters Phemisters deleted the dt-picker-docs branch April 17, 2025 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0