8000 Panasonic DC-S5M2 and DC-S5M2X support (data only) by kmilos · Pull Request #427 · darktable-org/rawspeed · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Panasonic DC-S5M2 and DC-S5M2X support (data only) #427

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 13, 2025
Merged

Panasonic DC-S5M2 and DC-S5M2X support (data only) #427

merged 2 commits into from
May 13, 2025

Conversation

kmilos
Copy link
Collaborator
@kmilos kmilos commented Feb 14, 2023 •
edited
Loading

Partly addresses darktable-org/darktable#13511 and darktable-org/darktable#15446

Used ADC 15.2. Crop is unverified.

This depends on v8 decoder working.

@kmilos kmilos requested a review from LebedevRI as a code owner February 14, 2023 08:31
@codecov
Copy link
codecov bot commented Feb 14, 2023 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.91%. Comparing base (13a3318) to head (55a242d).
Report is 169 commits behind head on develop.

Additional details and impacted files 
@@           Coverage Diff            @@
##           develop     #427   +/-   ##
========================================
  Coverage    60.91%   60.91%           
========================================
  Files          271      271           
  Lines        16366    16366           
  Branches      2077     2077           
========================================
  Hits          9969     9969           
  Misses        6268     6268           
  Partials       129      129
Flag Coverage Δ
benchmarks 11.84% <ø> (ø)
integration 45.05% <ø> (ø)
linux 57.10% <ø> (ø)
macOS 25.16% <ø> (ø)
rpu_u 45.05% <ø> (ø)
unittests 21.52% <ø> (ø)
windows ∅ <ø> (∅)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kmilos
Copy link
Collaborator Author
kmilos commented Apr 18, 2023

Adding DC-S5M2X as alias (for testing? could/should be separated later?) - it's the same camera w/ additional FW capabilities: https://www.dpreview.com/reviews/panasonic-lumix-dc-s5-ii-dc-s5-iix-initial-review

Also verified the profile is the same in latest ADC 15.3 addition.

@kmilos
Copy link
Collaborator Author
kmilos commented Sep 18, 2023

Adding DC-S5M2X as alias (for testing? could/should be separated later?)

I have now separated DC-S5M2X as an independent model. More samples have been uploaded.

@LebedevRI
Copy link
Member

Verified the samples.
I suppose someone could try porting the v8 decoder from RT/libraw.

@kmilos
Copy link
Collaborator Author
kmilos commented Sep 18, 2023

I suppose someone could try porting the v8 decoder from RT/libraw.

Yes please @jdneumeyer77 😉

It's not public yet though AFAIK...

@jdneumeyer77
Copy link
Contributor

@kmilos Happy to port it once it's publicly available. I don't own the GH6, S5ii or S5ii-x. So I'll use the samples.

@LebedevRI
Copy link
Member

@jdneumeyer77 yes, please.

@kmilos
Copy link
Collaborator Author
kmilos commented Feb 22, 2024

yes, please.

Still no public reference code available AFAIK 😞 (CC @mlouielu)

@LebedevRI
Copy link
Member

cough adobe dng converter cough Ghidra cough

@codecov-commenter
Copy link
codecov-commenter commented May 24, 2024 •
edited by codecov bot
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.91%. Comparing base (13a3318) to head (55a242d).
Report is 424 commits behind head on develop.

Additional details and impacted files 
@@           Coverage Diff            @@
##           develop     #427   +/-   ##
========================================
  Coverage    60.91%   60.91%           
========================================
  Files          271      271           
  Lines        16366    16366           
  Branches      2077     2077           
========================================
  Hits          9969     9969           
  Misses        6268     6268           
  Partials       129      129
Flag Coverage Δ
benchmarks 11.84% <ø> (ø)
integration 45.05% <ø> (ø)
linux 57.10% <ø> (ø)
macOS 25.16% <ø> (ø)
rpu_u 45.05% <ø> (ø)
unittests 21.52% <ø> (ø)
windows ∅ <ø> (∅)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@kmilos kmilos changed the title Panasonic DC-S5M2 support (data only) Panasonic DC-S5M2 and DC-S5M2X support (data only) Mar 13, 2025
@LebedevRI
Copy link
Member

Looking at RPU, and unlike the DC-S5M2X variant, here we only have the "basic" (14-bit?) raw, and the 96MPix one,
no 12-bit burst raw.

@kmilos
Copy link
Collaborator Author
kmilos commented Apr 29, 2025

Looking at RPU, and unlike the DC-S5M2X variant, here we only have the "basic" (14-bit?) raw, and the 96MPix one,
no 12-bit burst raw.

@dgermin2 @JaviMat @MrLimatex @jcampbell05 @elenaeli @AndrewKeYanzhe @MrCaliC

@AndrewKeYanzhe
Copy link

Looking at RPU, and unlike the DC-S5M2X variant, here we only have the "basic" (14-bit?) raw, and the 96MPix one,
no 12-bit burst raw.

@dgermin2 @JaviMat @MrLimatex @jcampbell05 @elenaeli @AndrewKeYanzhe @MrCaliC

I have uploaded a 12 bit electronic shutter burst RAW for the S5M2 at https://raw.pixls.us/ . Does it take a while to show up in the repo?

@kmilos
Copy link
Collaborator Author
kmilos commented Apr 29, 2025

I have uploaded a 12 bit electronic shutter burst RAW for the S5M2

Thank you! @AndrewKeYanzhe

Does it take a while to show up in the repo?

It does indeed, after a manual review...

@LebedevRI
Copy link
Member

Looking at RPU, and unlike the DC-S5M2X variant, here we only have the "basic" (14-bit?) raw, and the 96MPix one,
no 12-bit burst raw.

@dgermin2 @JaviMat @MrLimatex @jcampbell05 @elenaeli @AndrewKeYanzhe @MrCaliC

I have uploaded a 12 bit electronic shutter burst RAW for the S5M2 at https://raw.pixls.us/ . Does it take a while to show up in the repo?

Please can you contribute a new whole set instead, including the sample you've just uploaded?
(all images should be of a static daylight landscape-y scenery, with static-ish camera)

@AndrewKeYanzhe
Copy link

Looking at RPU, and unlike the DC-S5M2X variant, here we only have the "basic" (14-bit?) raw, and the 96MPix one,
no 12-bit burst raw.

@dgermin2 @JaviMat @MrLimatex @jcampbell05 @elenaeli @AndrewKeYanzhe @MrCaliC

I have uploaded a 12 bit electronic shutter burst RAW for the S5M2 at https://raw.pixls.us/ . Does it take a while to show up in the repo?

Please can you contribute a new whole set instead, including the sample you've just uploaded? (all images should be of a static daylight landscape-y scenery, with static-ish camera)

I have uploaded a new set with normal 14 bit, electronic burst 12 bit and 96 MP high res mode

@LebedevRI
Copy link
Member

@AndrewKeYanzhe thank you for contributing the sample set! i've verified it replacing the previous one.

@LebedevRI LebedevRI merged commit 8d056be into darktable-org:develop May 13, 2025
9 of 14 checks passed
@github-project-automation github-project-automation bot moved this from Requires New Raw Format Support to Resolved in New Camera Support May 13, 2025
@kmilos kmilos deleted the panny_s5m2 branch May 14, 2025 10:25
@kmilos kmilos moved this from Resolved to Done, not propagated to stable in New Camera Support May 14, 2025
@kmilos kmilos removed the incomplete label May 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LebedevRI LebedevRI Awaiting requested review from LebedevRI LebedevRI is a code owner

Assignees
No one assigned
Labels
None yet
Projects
New Camera Support
Status: Done, not propagated to stable
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@kmilos @LebedevRI @jdneumeyer77 @codecov-commenter @AndrewKeYanzhe
0