8000 CI: slim down MSYS2 install by kmilos · Pull Request #738 · darktable-org/rawspeed · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

CI: slim down MSYS2 install #738

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 28, 2024
Merged

CI: slim down MSYS2 install #738

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 2 additions & 9 deletions .github/workflows/CI-windows-msys2.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,9 +51,6 @@ jobs:
cache: false
msystem: ${{ inputs.msys2-msystem }}
update: false
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As per https://github.com/msys2/setup-msys2?tab=readme-ov-file#update,
that means we don't update the package index either? That seems unfortunate.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that this was off before my change.

Not really an issue IMHO as you're not interested in testing the latest MSYS2 packages but your code. The msys2-installer and the setup-msys2 action get an update every 3 months or so anyway.

install: >-
git
base-devel
pacboy: >-
cc:p
gcc-libs:p
Expand All @@ -67,12 +64,8 @@ jobs:
- name: Install Additional Dependencies (Coverage)
if: inputs.flavor == 'Coverage'
timeout-minutes: 1
uses: msys2/setup-msys2@v2
with:
cache: false
msystem: ${{ inputs.msys2-msystem }}
pacboy: >-
zstd:p
run: |
pacboy --noconfirm -S --needed zstd:p
- name: Configure
timeout-minutes: 3
env:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/CI.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -178,7 +178,7 @@ jobs:
matrix:
include:
- os: windows-latest
msys2: { msystem: MINGW64, arch: x86_64, family: GNU, CC: gcc, CXX: g++ }
msys2: { msystem: UCRT64, arch: x86_64, family: GNU, CC: gcc, CXX: g++ }
flavor: Coverage
uses: ./.github/workflows/CI-windows-msys2.yml
with:
Expand Down
Loading
0