PanasonicV8Decompressor refactor: the obvious parts #847
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
```
/home/lebedevri/rawspeed/src/librawspeed/decompressors/PanasonicV8Decompressor.cpp:223:3: runtime error: unsigned integer overflow: 0 - 1 cannot be represented in type 'unsigned int'
#0 0x55e5f66882c6 in rawspeed::PanasonicV8Decompressor::decompress() const (.omp_outlined_debug__) /home/lebedevri/rawspeed/src/librawspeed/decompressors/PanasonicV8Decompressor.cpp:223:3
```
…xplicit
```
/home/lebedevri/rawspeed/src/librawspeed/decompressors/PanasonicV8Decompressor.cpp:345:11: runtime error: implicit conversion from type 'int' of value -4 (32-bit, signed) to type 'uint32_t' (aka 'unsigned int') changed the value to 4294967292 (32-bit, unsigned)
#0 0x5579dd23e093 in rawspeed::PanasonicV8Decompressor::InternalHuffDecoder::decodeNextDiffValue() /home/lebedevri/rawspeed/src/librawspeed/decompressors/PanasonicV8Decompressor.cpp:345:11
```
```
/home/lebedevri/rawspeed/src/librawspeed/decompressors/PanasonicV8Decompressor.cpp:344:67: runtime error: negation of 1 cannot be represented in type 'unsigned int'
#0 0x55abbb54500d in rawspeed::PanasonicV8Decompressor::InternalHuffDecoder::decodeNextDiffValue() /home/lebedevri/rawspeed/src/librawspeed/decompressors/PanasonicV8Decompressor.cpp:344:67
```
…T()` out of class
Decompressors aren't allowed to know about TIFF IFD.
Not needed since no longer in openmp structured block
IFD eradication complete
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.