8000 1.27.0 by pq · Pull Request #3576 · dart-archive/linter · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
This repository was archived by the owner on Nov 20, 2024. It is now read-only.

1.27.0 #3576

Merged
merged 6 commits into from
Aug 8, 2022
Merged

1.27.0 #3576

merged 6 commits into from
Aug 8, 2022

Conversation

pq
Copy link
Contributor
@pq pq commented Aug 2, 2022

1.27.0

  • new lint: use_string_in_part_of_directives
  • fixed use_super_parameters false positive with repeated super
    parameter references
  • updated use_late_for_private_fields_and_variables to handle enums
  • fixed prefer_contains false positive when start index is non-zero
  • improved noop_primitive_operations to catch .toString()
    in string interpolations
  • updated public_member_api_docs to report diagnostics on extension
    names (instead of bodies)
  • miscellaneous documentation improvements
  • (internal): DartTypeUtilities refactoring

/cc @srawlins @bwilkerson @parlough @a14n

@coveralls
Copy link
coveralls commented Aug 2, 2022 •
edited
Loading

Coverage Status

Coverage increased (+0.001%) to 95.473% when pulling df82312 on 1.27.0 into b677397 on main.

@pq
Copy link
Contributor Author
pq commented Aug 2, 2022

For those following along, this release is getting tested for landing in the SDK here: https://dart-review.googlesource.com/c/sdk/+/253501.

Currently it's blocked on some pending fixes to flutter_tools and plugins to address new noop_primitive_operations diagnostics (flutter/flutter#108836 and flutter/plugins#6173 respectively). We may need to make similar proactive fixes in Google3 too. We'll certainly need to accommodate @srawlins's DartTypeUtilities refactorings.

@srawlins
Copy link
Contributor
srawlins commented Aug 2, 2022

We'll certainly need to accommodate @srawlins's DartTypeUtilities refactorings.

Why will we need to accommodate those? They should be backwards compatible.

@pq
Copy link
Contributor Author
pq commented Aug 3, 2022

Why will we need to accommodate those? They should be backwards compatible.

Sorry, yeah. I was under the mistaken impression that deprecations would be breaking. Glad to hear I was wrong!

@pq pq merged commit 075a3b6 into main Aug 8, 20 8000 22
@pq pq deleted the 1.27.0 branch August 8, 2022 17:19
@pq
Copy link
Contributor Author
pq commented Aug 8, 2022

Note: includes fix to accommodate deflake here: dart-lang/sdk#49596

copybara-service bot pushed a commit to dart-lang/sdk that referenced this pull request Aug 23, 2023
@pq @domesticmouse
1.27.0 (dart-archive/linter#3576)
e835ee9 
* 1.27.0

* Insert reasoning for `avoid_function_literals_in_foreach_calls` lint (dart-archive/linter#3545)

* Update avoid_function_literals_in_foreach_calls.dart

* Second attempt

* Add a the to make for betterer english

* convert unnecessary `.from`s to `.of`s (dart-archive/linter#3577)

* deflake `avoid_redundant_argument_values`

* ++

Co-authored-by: Brett Morgan <brett.morgan@gmail.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@srawlins srawlins srawlins approved these changes

@bwilkerson bwilkerson bwilkerson approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@pq @coveralls @srawlins @bwilkerson @domesticmouse
0