8000 OpenID's id_token implementation by wesleyfantinel · Pull Request #47 · dart-archive/oauth2 · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
This repository was archived by the owner on Aug 26, 2024. It is now read-only.

OpenID's id_token implementation #47

Merged
merged 8 commits into from 8000
Oct 4, 2019
Merged

OpenID's id_token implementation #47

merged 8 commits into from
Oct 4, 2019

Conversation

wesleyfantinel
Copy link
Contributor

This manage the OpenID id_token response, including it on the access token and credentials.

At this moment, the library doesn't provide a way to decode the id_token that has a JWT format. You should implement it in your application level.

Closes #8

Copy link
Contributor
@jonasfj jonasfj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, for the late review, I totally forgot this.

If you want to undertake the final nits, most importantly bumping the version number I'll be happy to ship this :)

@wesleyfantinel
Copy link
Contributor Author

Thank you for the review.

I think we are good to go :)

8000
Copy link
Contributor
@jonasfj jonasfj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super quick.. maybe rebase or merge to solve the conflict and update version number in CHANGELOG.

@wesleyfantinel wesleyfantinel requested a review from jonasfj October 4, 2019 12:47
Copy link
Contributor
@jonasfj jonasfj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, I just used githubs nice fix merge conflict :)

< 8000 div data-view-component="true" class="comment-reactions js-reactions-container js-reaction-buttons-container social-reactions reactions-container has-reactions d-flex">
wesleyfantinel reacted with thumbs up emoji
@jonasfj
Copy link
Contributor
jonasfj commented Oct 4, 2019

I'll merge once travis passes, ping me if I forget.

@wesleyfantinel wesleyfantinel requested a review from jonasfj October 4, 2019 12:56
@jonasfj jonasfj merged commit bf8174d into dart-archive:master Oct 4, 2019
mosuem pushed a commit to dart-lang/tools that referenced this pull request Aug 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Development

Successfully merging this pull request may close these issues.

Extend OAuth2 package to support OpenID connect
3 participants
0