-
Notifications
You must be signed in to change notification settings - Fork 128
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, for the late review, I totally forgot this.
If you want to undertake the final nits, most importantly bumping the version number I'll be happy to ship this :)
Thank you for the review. I think we are good to go :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Super quick.. maybe rebase or merge to solve the conflict and update version number in CHANGELOG.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, I just used githubs nice fix merge conflict :)
I'll merge once travis passes, ping me if I forget. |
OpenID's id_token implementation
This manage the OpenID id_token response, including it on the access token and credentials.
At this moment, the library doesn't provide a way to decode the id_token that has a JWT format. You should implement it in your application level.
Closes #8