feat: add trivy #164
Open
feat: add trivy #164
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ivy vulnerability scanning
…e path in push image step
puehringer
reviewed
Apr 15, 2025
puehringer
reviewed
Apr 15, 2025
puehringer
reviewed
Apr 15, 2025
puehringer
reviewed
Apr 15, 2025
puehringer
reviewed
Apr 15, 2025
…workflows into feat/add-trivy
…workflows into feat/add-trivy
|
PR ready for review @puehringer @dvvanessastoiber @dvviktordelev |
|
@dv-hossam-radwan did a test run with this PR and visynKB in case you want to take a look: https://github.com/datavisyn/visyn_kb/actions/runs/15003505026 |
puehringer
reviewed
May 13, 2025
puehringer
reviewed
May 14, 2025
| exit-code: '1' | ||
| ignore-unfixed: false | ||
| vuln-type: 'os,library' | ||
| severity: 'MEDIUM,HIGH,CRITICAL' |
There was a problem hiding this comment.
I'm not sure if 57A7 we should treat medium ones...
Suggested change
| severity: 'MEDIUM,HIGH,CRITICAL' | |
| severity: 'HIGH,CRITICAL' |
There was a problem hiding this comment.
High and critical ones should be sufficient as we did the same in the old pipeline 👍 interestingly, GSK only checks for critical vulnerabilites, but I would like to keep the high ones as well 😅
dvvanessastoiber
approved these changes
May 19, 2025
There was a problem hiding this comment.
Looks good to me code-wise 👍 let's also wait for approval by @puehringer and @dvviktordelev
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.