8000 Add assets/*/*.yml to includes in templates by fjakobs · Pull Request #2923 · databricks/cli · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Add assets/*/*.yml to includes in templates #2923

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add assets/*/*.yml to includes in templates #2923

wants to merge 1 commit into from

Conversation

fjakobs
Copy link
Contributor
@fjakobs fjakobs commented May 22, 2025

Changes

Update templates to also include yaml files from assets/*/*.yml.

Why

Tests

@fjakobs fjakobs temporarily deployed to test-trigger-is May 22, 2025 12:54 — with GitHub Actions Inactive
lennartkats-db
lennartkats-db reviewed May 22, 2025
View reviewed changes
Copy link
Contributor
@lennartkats-db lennartkats-db left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should discuss if we want to proactively add these imports. I think it may be better to add them on demand if assets are added. And to only add this to the template if we do a further revamp of the template.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lennartkats-db lennartkats-db lennartkats-db left review comments

@pietern pietern Awaiting requested review from pietern pietern is a code owner

@shreyas-goenka shreyas-goenka Awaiting requested review from shreyas-goenka shreyas-goenka is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fjakobs @lennartkats-db
0