8000 feat: use sub instead of id to check admin rights by XavierJp · Pull Request #41 · datagouv/d-roles · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

feat: use sub instead of id to check admin rights #41

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Jun 16, 2025
Merged

feat: use sub instead of id to check admin rights #41

merged 7 commits into from
Jun 16, 2025

Conversation

XavierJp
Copy link
Contributor
@XavierJp XavierJp commented Jun 4, 2025 •
edited
Loading
  • use proconnect sub rather than user ID to check for admin rights over group manipulation
  • need to find a way to update proconnect sub on first connexion as it is not required for user creation
  • ensure it is impossible to remove admin or to change it's role when it is the only admin in team

closes #35
closes #39

@XavierJp XavierJp requested a review from a team as a code owner June 4, 2025 10:08
@hacherix
Copy link
Collaborator
hacherix commented Jun 6, 2025

Joli! 🚀

hacherix
hacherix reviewed Jun 6, 2025
View reviewed changes
@XavierJp XavierJp merged commit eb5c78d into main Jun 16, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hacherix hacherix hacherix approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

utiliser le slug et pas l'id pour les actions de management d'équipe S'assurer qu'on ne peut pas supprimer l'admin
2 participants
@XavierJp @hacherix
0