8000 add document generation to tox by gaborbernat · Pull Request #568 · dateutil/dateutil · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

add document generation to tox #568

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 7, 2017
Merged

add document generation to tox #568

merged 1 commit into from
Dec 7, 2017

Conversation

gaborbernat
Copy link
Contributor

and trigger automatically at CI (also check links in documentation to avoid having dangling pointers to the internet)

… check links in documentation to avoid having dangling pointers to the internet)
@@ -8,7 +8,7 @@

from dateutil.tz import tzfile as _tzfile

__all__ = ["get_zonefile_instance", "gettz", "gettz_db_metadata", "rebuild"]
__all__ = ["get_zonefile_instance", "gettz", "gettz_db_metadata"]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we can change the public interface like this...

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm, actually rebuild is a separate file. Yeah, I see how this works. This is fine.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the problem here is that this import does not work, the Sphinx could not load it, as no import is there. how is this rebuild suppose to exist?

@pganssle
Copy link
Member
pganssle commented Dec 7, 2017

This is awesome, thanks @gaborbernat. I'll merge once CI passes.

@gaborbernat gaborbernat mentioned this pull request Dec 7, 2017
@gaborbernat
Copy link
Contributor Author
gaborbernat commented Dec 7, 2017

tox -e docs will now build to .tox\docs_out the documentation (on any platform) 👍 with this we could probably try to deprecate the makefile and build.bat files in the doc folder.

@pganssle pganssle added this to the 2.7.0 milestone Dec 7, 2017
@pganssle pganssle merged commit fa11a15 into dateutil:master Dec 7, 2017
@pganssle pganssle mentioned this pull request Mar 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0