Support for TZID= in rrulestr #624
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for merging this :)! |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a fixup PR for #619, see the discussion there for more details. It fixes #614.
I realized that
tzinfosin the parser andtzidwant slightly different things in this scenario. Considering that the RFC is actually a lot stricter thandateutil.parser.parseabout the format of the dates, in a future version I will try to deprecate the looser parser, possibly in favor ofdateutil.parser.isoparse.Either way I'll probably deprecate the use of
tzinfos, since the RFC dictates that the time zone should go in theTZIDparameter, not the datetime itself.