10000 Added examples to tzfile docstring by weatherpattern · Pull Request #671 · dateutil/dateutil · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Added examples to tzfile docstring #671

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 25, 2018
Merged

Added examples to tzfile docstring #671

merged 2 commits into from
Apr 25, 2018

Conversation

weatherpattern
Copy link
Contributor

Added examples to the tzfile to the docstring.
Note sure if there was a format you wanted.

Relates to #443

@pganssle
Copy link
Member

I think these need to be in .. code-block or .. doctest blocks.

That said, I don't think people are supposed to directly create tzfile objects, so I think these examples might need a bit of context. I can handle that part, though.

@weatherpattern
Copy link
Contributor Author
weatherpattern commented Apr 15, 2018 •
edited
Loading

Thanks for taking a look.
I am not familiar this doctest blocks but based on the sphinx doctest documentation, I tried to match the example in tzrange.

If you'd like any other changes, please let me know.

@pganssle pganssle added this to the 2.7.3 milestone Apr 23, 2018
@pganssle pganssle force-pushed the examples-improvement-tzfile branch 2 times, most recently from 902636d to 990d873 Compare April 24, 2018 19:05
@pganssle pganssle mentioned this pull request Apr 24, 2018
Closed
@pganssle pganssle force-pushed the examples-improvement-tzfile branch from 990d873 to 0c38900 Compare April 24, 2018 23:52
@pganssle pganssle merged commit 7a99868 into dateutil:master Apr 25, 2018
@pganssle pganssle mentioned this pull request May 9, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
documentation
Projects
None yet
Milestone
2.7.3
Development

Successfully merging this pull request may close these issues.
2 participants
@weatherpattern @pganssle
0