8000 dbeaver/pro#5886 core api for permission management by alexander-skoblikov · Pull Request #3519 · dbeaver/cloudbeaver · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

dbeaver/pro#5886 core api for permission management #3519

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 6 commits into
base: devel
Choose a base branch
from
Open

dbeaver/pro#5886 core api for permission management #3519

wants to merge 6 commits into from

Conversation

alexander-skoblikov
Copy link
Collaborator

close dbeaver/pro#5886

HocKu7
HocKu7 reviewed Jun 13, 2025
View reviewed changes
...eaver.service.security/src/io/cloudbeaver/service/security/CBEmbeddedSecurityController.java Outdated
}
}
}
if (!CommonUtils.isEmpty(forInsert)) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't like that we group up a sql queries and logic in one place - the controller. Can we extract SQL queries on repo/service level?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HocKu7 HocKu7 HocKu7 left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alexander-skoblikov @HocKu7
0