[CB] implement ui-kit spinner #6017 #3532
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR replaces the custom static-image spinners in Loader with the new Spinner component from the UI kit and updates CSS accordingly, and switches an InputField loading indicator from Spinner to Loader.
- Swap out multiple
<StaticImage>icons for a single<Spinner>inLoader.tsx - Add new CSS variables and remove old static-image rules in
Loader.module.css - Update
InputFieldBaseto use<Loader>instead of<Spinner>
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| webapp/packages/core-blocks/src/Loader/Loader.tsx | Removed StaticImage spinner icons and spinnerType; imported and rendered Spinner |
| webapp/packages/core-blocks/src/Loader/Loader.module.css | Added CSS variables for spinner sizes/colors; removed old static-image/rotation rules |
| webapp/packages/core-blocks/src/FormControls/InputField/InputFieldBase.tsx | Changed inline spinner to use Loader component |
Comments suppressed due to low confidence (2)
webapp/packages/core-blocks/src/FormControls/InputField/InputFieldBase.tsx:139
- The new Loader displays a loading message by default. To match the original spinner-only behavior, consider passing
hideMessage(e.g.,<Loader small hideMessage />).
<Loader small />
webapp/packages/core-blocks/src/Loader/Loader.tsx:272
- Add or update unit tests for
Loaderto verify that theSpinnerintegration applies the correctsizeand secondary classes under different prop combinations.
<Spinner
Wroud
requested changes
Jun 18, 2025
webapp/packages/core-blocks/src/FormControls/InputField/InputFieldBase.tsx
Outdated
Show resolved
Hide resolved
SychevAndrey
approved these changes
Jun 18, 2025
Wroud
approved these changes
Jun 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes https://github.com/dbeaver/pro/issues/6017