8000 Add XProj dependency by scottyhq · Pull Request #29 · dcherian/rasterix · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Add XProj dependency #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Add XProj dependency #29

wants to merge 2 commits into from

Conversation

scottyhq
Copy link
Collaborator

Addresses #13

Also adds some more development notes (I'm new to hatch so took a bit to understand how to use it)

@scottyhq scottyhq requested a review from benbovy May 13, 2025 12:58
Comment on lines 10 to 11
# TODO: hook up xproj to remove need for import?
import xproj
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To avoid needing to do the import here looking into integrating (https://xproj.readthedocs.io/en/latest/integration.html) into existing code...

class RasterIndex(Index):
"""Xarray index for raster coordinates.

@dcherian
Copy link
Owner

Nice, please merge whenever you all think this is ready.

@scottyhq
Copy link
Collaborator Author

While this 'works' after talking with @benbovy we're thinking a better strategy to actually address #13 is to not yet have xproj as a dependency and instead focus on this case:

  1. Ensure CRS-matching during (exact) alignment of datasets even in cases where a spatial reference coordinate is missing

https://github.com/xarray-contrib/xvec/blob/5affd7ac591bbdef2722c5eac4b976823384e8ed/xvec/index.py#L102-L111

The xproj integration can happen later as it would needed for specific use-cases (xarray-contrib/xproj#25) but not necessarily required as a dependency

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0