8000 feat: support YMap controls by ddubrava · Pull Request #239 · ddubrava/angular-yandex-maps · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

feat: support YMap controls #239

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 14, 2024
Merged

feat: support YMap controls #239

merged 1 commit into from
Jul 14, 2024

Conversation

ddubrava
Copy link
Owner

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Refactoring
  • Build or CI related changes
  • Documentation content changes

What is the current behavior?

Control components are not supported.

What is the new behavior?

Control components are supported.

Does this PR introduce a breaking change?

  • Yes
  • No

@ddubrava ddubrava marked this pull request as draft July 13, 2024 14:31
@ddubrava ddubrava changed the title feat: support YMapControls, YMapControlButton, YMapControlCommonButton and YMapScaleControl feat: support YMap controls Jul 13, 2024
@codecov Codecov
Copy link
codecov bot commented Jul 13, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 96.09756% with 8 lines in your changes missing coverage. Please review.

Project coverage is 98.11%. Comparing base (f9bb32d) to head (ce86866).
Report is 2 commits behind head on main.

Files Patch % Lines
.../controls/y-map-control/y-map-control.directive.ts 75.75% 8 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #239      +/-   ##
==========================================
- Coverage   98.64%   98.11%   -0.54%     
==========================================
  Files          24       32       +8     
  Lines         888     1060     +172     
  Branches       89       95       +6     
==========================================
+ Hits          876     1040     +164     
- Misses          6       14       +8     
  Partials        6        6
Flag Coverage Δ
angular-yandex-maps-v2 98.47% <ø> (ø)
angular-yandex-maps-v3 97.51% <96.09%> (-1.62%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ddubrava ddubrava force-pushed the support-controls branch 3 times, most recently from 225ea81 to 2d17b0e Compare July 14, 2024 16:17
@ddubrava ddubrava marked this pull request as ready for review July 14, 2024 16:23
@ddubrava ddubrava merged commit 7aedbcf into main Jul 14, 2024
3 of 5 checks passed
@ddubrava ddubrava deleted the support-controls branch July 14, 2024 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ddubrava
0