8000 Reduce Makefile duplication by cadmic · Pull Request #71 · decompals/ido-static-recomp · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Reduce Makefile duplication #71

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally 8000 send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 23, 2025
Merged

Reduce Makefile duplication #71

merged 2 commits into from
Feb 23, 2025

Conversation

cadmic
Copy link
Contributor
@cadmic cadmic commented Feb 23, 2025

N32 will need yet another libc_impl version, and the "exceptions" were growing out of control. So, I tried to reduce the duplication in the build rules.

Changes:

  • There's now a makefile template for the build steps, to handle building two different targets for macOS universal binaries. Apparently there was something like this in the past and it was removed because it was not readable, but hopefully it's a bit better this time.
  • Instead of libc_impl.o (either 5.3 or 7.1 depending on version) and libc_impl_53.o (always 5.3), there's libc_impl_53.o and libc_impl_71.o which are always built with the same flags. The right version is selected by overriding LIBC_IMPL per-target. Maybe it's a bit wasteful to build 7.1 libc for 5.3 programs but it builds fast
  • version_info.o no longer depends on all program .o files. Previously it was impossible to only build a single program.o file, and it prevented per-target variable overrides from working because makefile also uses the overrides for any dependencies.

@AngheloAlf AngheloAlf merged commit 1f0f9f2 into decompals:main Feb 23, 2025
8 checks passed
@cadmic cadmic deleted the makefile-template branch February 25, 2025 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AngheloAlf AngheloAlf AngheloAlf approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cadmic @AngheloAlf
0