8000 [dhctl] Set additionalProperties "false" for all objects in openapi by alexey-gavrilov-flant · Pull Request #11832 · deckhouse/deckhouse · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[dhctl] Set additionalProperties "false" for all objects in openapi #11832

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 89 commits into from
Apr 9, 2025
Merged

[dhctl] Set additionalProperties "false" for all objects in openapi #11832

merged 89 commits into from
Apr 9, 2025

Conversation

alexey-gavrilov-flant
Copy link
Member
@alexey-gavrilov-flant alexey-gavrilov-flant commented Jan 30, 2025 •
edited by denmaloyreb
Loading

Description

Ported the schema transformation from addon-operator.
Upgrade phase v+1

Why do we need it, and what problem does it solve?

Closed #2828

Why do we need it in the patch release (if we do)?

Checklist

  • The code is covered by unit tests.
  • e2e tests passed.
  • Documentation updated according to the changes.
  • Changes were tested in the Kubernetes cluster manually.

Changelog entries

section: dhctl
type: chore
summary: Set `additionalProperties` `false` for all objects in openapi.
impact_level: default

@alexey-gavrilov-flant
[dhctl] Set additionalProperties: false for all objects
591c622 
Signed-off-by: Aleksey Gavrilov <alexey.gavrilov@flant.com>
@alexey-gavrilov-flant alexey-gavrilov-flant added this to the v1.69.0 milestone Jan 30, 2025
@alexey-gavrilov-flant alexey-gavrilov-flant self-assigned this Jan 30, 2025
@github-actions github-actions bot added area/cli Pull requests that update cli go Pull requests that update Go code labels Jan 30, 2025
@alexey-gavrilov-flant
item 20830
a6e077e 
Signed-off-by: Aleksey Gavrilov <alexey.gavrilov@flant.com>
@alexey-gavrilov-flant
item 9134
47c1bdc 
Signed-off-by: Aleksey Gavrilov <alexey.gavrilov@flant.com>
@alexey-gavrilov-flant
item 19986
39dffe4 
Signed-off-by: Aleksey Gavrilov <alexey.gavrilov@flant.com>
@alexey-gavrilov-flant
Merge remote-tracking branch 'origin/main' into core/dhctl-validator-…
2943382 
…ModuleConfig

Signed-off-by: Aleksey Gavrilov <alexey.gavrilov@flant.com>
@alexey-gavrilov-flant
item 29342
bb15edc 
Signed-off-by: Aleksey Gavrilov <alexey.gavrilov@flant.com>
@alexey-gavrilov-flant
item 1934
940c53b 
Signed-off-by: Aleksey Gavrilov <alexey.gavrilov@flant.com>
@alexey-gavrilov-flant
item 18713
bc4451c 
Signed-off-by: Aleksey Gavrilov <alexey.gavrilov@flant.com>
@alexey-gavrilov-flant
item 15560
fb0f98f 
Signed-off-by: Aleksey Gavrilov <alexey.gavrilov@flant.com>
@alexey-gavrilov-flant alexey-gavrilov-flant added the e2e/run/openstack Run e2e tests in OpenStack label Jan 31, 2025
@deckhouse-BOaTswain
Copy link
Collaborator
deckhouse-BOaTswain commented Jan 31, 2025 •
edited
Loading

🔴 e2e: OpenStack for deckhouse:core/dhctl-validator-ModuleConfig failed in 2m5s.

E2e for openstack Standard;containerd;1.29 was failed. Use:

/e2e/abort openstack;Standard;containerd;1.29 13069745398 13069745398-1-con-1-29 /sys/deckhouse-oss/install:pr11832 - for abort failed cluster

Workflow details (1 job failed)

🔴 e2e: OpenStack, Containerd, Kubernetes 1.29 failed in 1m29s.

@github-actions github-actions bot removed the e2e/run/openstack Run e2e tests in OpenStack label Jan 31, 2025
@deckhouse-BOaTswain deckhouse-BOaTswain added the e2e/cluster/failed Pull request contains failed e2e cluster label Jan 31, 2025
@alexey-gavrilov-flant
Copy link
Member Author

/e2e/abort openstack;Standard;containerd;1.29 13069745398 13069745398-1-con-1-29 /sys/deckhouse-oss/install:pr11832

@deckhouse-BOaTswain
Copy link
Collaborator
deckhouse-BOaTswain commented Jan 31, 2025 •
edited
Loading

🟢 destroy cluster: OpenStack for refs/heads/main succeeded in 37s.

Workflow details

🟢 destroy cluster: OpenStack, Containerd, Kubernetes 1.29 succeeded in 14s.

@deckhouse-BOaTswain deckhouse-BOaTswain removed the e2e/cluster/failed Pull request contains failed e2e cluster label Jan 31, 2025
@alexey-gavrilov-flant
item 19884
011084e 
Signed-off-by: Aleksey Gavrilov <alexey.gavrilov@flant.com>
@github-actions github-actions bot added area/cloud-provider Pull requests that update cloud providers modules area/cluster-and-infrastructure Pull requests that update infra modules area/api-change Pull requests that api changing labels Jan 31, 2025
@alexey-gavrilov-flant
item 14675
a254bdd 
Signed-off-by: Aleksey Gavrilov <alexey.gavrilov@flant.com>
@alexey-gavrilov-flant
item 28747
d89df9d 
Signed-off-by: Aleksey Gavrilov <alexey.gavrilov@flant.com>
@alexey-gavrilov-flant
item 5481
65ed665 
Signed-off-by: Aleksey Gavrilov <alexey.gavrilov@flant.com>
@alexey-gavrilov-flant
item 31780
734dc3a 
Signed-off-by: Aleksey Gavrilov <alexey.gavrilov@flant.com>
@alexey-gavrilov-flant alexey-gavrilov-flant added the e2e/run/openstack Run e2e tests in OpenStack label Jan 31, 2025
@deckhouse-BOaTswain
Copy link
Collaborator
deckhouse-BOaTswain commented Jan 31, 2025 •
edited
Loading

🟢 e2e: OpenStack for deckhouse:core/dhctl-validator-ModuleConfig succeeded in 27m30s.

Workflow details

OpenStack-Standard-Containerd-1.29 - Connection string: ssh redos@5.159.101.219

🟢 e2e: OpenStack, Containerd, Kubernetes 1.29 succeeded in 26m49s.

@github-actions github-actions bot removed area/docs Pull requests that update doumentation area/cluster-and-infrastructure Pull requests that update infra modules area/api-change Pull requests that api changing labels Mar 24, 2025
@alexey-gavrilov-flant
item 27471
0b8cd3f 
Signed-off-by: Aleksey Gavrilov <alexey.gavrilov@flant.com>
@alexey-gavrilov-flant
item 18977
059a742 
Signed-off-by: Aleksey Gavrilov <alexey.gavrilov@flant.com>
@alexey-gavrilov-flant alexey-gavrilov-flant changed the title [dhctl] Set additionalProperties: false for all objects [dhctl] Set additionalProperties "false" for all objects in openapi Mar 24, 2025
@alexey-gavrilov-flant
item 27725
242630b 
Signed-off-by: Aleksey Gavrilov <alexey.gavrilov@flant.com>
@alexey-gavrilov-flant
item 15919
e8493a2 
Signed-off-by: Aleksey Gavrilov <alexey.gavrilov@flant.com>
@alexey-gavrilov-flant
item 30300
f1aabda 
Signed-off-by: Aleksey Gavrilov <alexey.gavrilov@flant.com>
@alexey-gavrilov-flant alexey-gavrilov-flant added the e2e/run/yandex-cloud Run e2e tests in Yandex Cloud label Mar 24, 2025
@deckhouse-BOaTswain
8000
Copy link
Collaborator
deckhouse-BOaTswain commented Mar 24, 2025 •
edited
Loading

🟢 e2e: Yandex.Cloud for deckhouse:core/dhctl-validator-ModuleConfig succeeded in 33m44s.

Workflow details

Yandex.Cloud-WithoutNAT-Containerd-1.30 - Connection string: ssh redos@89.169.130.137

🟢 e2e: Yandex.Cloud, Containerd, Kubernetes 1.30 succeeded in 32m37s.

@github-actions github-actions bot removed the e2e/run/yandex-cloud Run e2e tests in Yandex Cloud label Mar 24, 2025
@alexey-gavrilov-flant
item 2341
65ee00e 
Signed-off-by: Aleksey Gavrilov <alexey.gavrilov@flant.com>
@miklezzzz miklezzzz mentioned this pull request Mar 24, 2025
Merged
4 tasks
@alexey-gavrilov-flant alexey-gavrilov-flant added the e2e/run/openstack Run e2e tests in OpenStack label Mar 24, 2025
@deckhouse-BOaTswain
Copy link
Collaborator
deckhouse-BOaTswain commented Mar 24, 2025 •
edited
Loading

🟢 e2e: OpenStack for deckhouse:core/dhctl-validator-ModuleConfig succeeded in 28m37s.

Workflow details

OpenStack-Standard-Containerd-1.30 - Connection string: ssh redos@37.9.4.123

🟢 e2e: OpenStack, Containerd, Kubernetes 1.30 succeeded in 27m29s.

@github-actions github-actions bot removed the e2e/run/openstack Run e2e tests in OpenStack label Mar 24, 2025
@alexey-gavrilov-flant alexey-gavrilov-flant marked this pull request as ready for review March 24, 2025 15:57
@alexey-gavrilov-flant alexey-gavrilov-flant marked this pull request as draft April 2, 2025 12:12
@alexey-gavrilov-flant alexey-gavrilov-flant marked this pull request as ready for review April 4, 2025 13:50
@name212 name212 self-requested a review April 8, 2025 20:34
@alexey-gavrilov-flant
Merge remote-tracking branch 'origin/main' into core/dhctl-validator-…
6c70fc8 
…ModuleConfig

Signed-off-by: Aleksey Gavrilov <alexey.gavrilov@flant.com>
@name212 name212 merged commit 6ee65e5 into main Apr 9, 2025
42 of 43 checks passed
@name212 name212 deleted the core/dhctl-validator-ModuleConfig branch April 9, 2025 17:45
@deckhouse-BOaTswain deckhouse-BOaTswain mentioned this pull request Apr 9, 2025
Open
RaveNoX pushed a commit that referenced this pull request Apr 10, 2025
@alexey-gavrilov-flant @z9r5
@maxinsky @Lada7878 @RaveNoX
[dhctl] Set additionalProperties "false" for all objects in openapi (#…
98c0da8 
…11832)

Signed-off-by: Aleksey Gavrilov <alexey.gavrilov@flant.com>
Signed-off-by: Artem Kladov <6360800+z9r5@users.noreply.github.com>
Signed-off-by: Max Chervov <max.chervov@gmail.com>
Co-authored-by: Artem Kladov <6360800+z9r5@users.noreply.github.com>
Co-authored-by: Max Chervov <max.chervov@gmail.com>
Co-authored-by: Lada Lysenko <127337005+Lada7878@users.noreply.github.com>
morhayn pushed a commit that referenced this pull request May 14, 2025
@alexey-gavrilov-flant @z9r5
@maxinsky @Lada7878 @morhayn
[dhctl] Set additionalProperties "false" for all objects in openapi (#…
4f0ffef 
…11832)

Signed-off-by: Aleksey Gavrilov <alexey.gavrilov@flant.com>
Signed-off-by: Artem Kladov <6360800+z9r5@users.noreply.github.com>
Signed-off-by: Max Chervov <max.chervov@gmail.com>
Co-authored-by: Artem Kladov <6360800+z9r5@users.noreply.github.com>
Co-authored-by: Max Chervov <max.chervov@gmail.com>
Co-authored-by: Lada Lysenko <127337005+Lada7878@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@z9r5 z9r5 z9r5 approved these changes

@sprait sprait sprait approved these changes

@name212 name212 name212 approved these changes

@nabokihms nabokihms Awaiting requested review from nabokihms nabokihms is a code owner

@RomanenkoDenys RomanenkoDenys Awaiting requested review from RomanenkoDenys

Assignees

@alexey-gavrilov-flant alexey-gavrilov-flant

Labels
area/cli Pull requests that update cli go Pull requests that update Go code
Projects
None yet
Milestone
v1.70.0
Development

Successfully merging this pull request may close these issues.

[dhctl] Set additionalProperties: false for all objects in Cluster, ProviderCluster configurations
7 participants
@alexey-gavrilov-flant @deckhouse-BOaTswain @z9r5 @sprait @name212 @RomanenkoDenys @maxinsky
0