10000 [dhctl] Implement native SSH client by YuryLysov · Pull Request #13240 · deckhouse/deckhouse · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[dhctl] Implement native SSH client #13240

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 13 commits into
base: main
Choose a base branch
from
Draft

[dhctl] Implement native SSH client #13240

wants to merge 13 commits into from
+3,884 −325

Conversation

YuryLysov
Copy link
Contributor
@YuryLysov YuryLysov commented Apr 28, 2025 •
edited
Loading

Description

Implement native go ssh client, which will be used by default. To keep using old cli ssh client, put --ssh-legacy-mode flag or use SSH_LEGACY_MODE environment variable set to true

Additionally, password authentication via SSH has been added. Target host password could be set by putting --ask-become-pass or ASK_BECOME_PASS environment variable. To set password for bastion host user, use flag --ask-bastion-pass or environment variable ASK_BASTION_PASS.

Why do we need it, and what problem does it solve?

  • Add ability to remove ssh-agent and ssh binaries in future
  • Add ability to use password authentication

Checklist

  • The code is covered by unit tests.
  • e2e tests passed.
  • Documentation updated according to the changes.
  • Changes were tested in the Kubernetes cluster manually.

Changelog entries

section: dhctl
type: chore
summary: Add native ssh client support to dhctl.
impact_level: default
---
section: dhctl
type: feature
summary: Add password authentication support to dhctl.
impact_level: default
---
section: candi
type: fix
summary: Fix deletion of NodeUsers.
impact_level: default

@YuryLysov YuryLysov added this to the v1.70.0 milestone Apr 28, 2025
@github-actions github-actions bot added area/cluster-and-infrastructure Pull requests that update infra modules type/dependencies Pull requests that update a dependency file area/cli Pull requests that update cli area/core Pull requests that update core modules go Pull requests that update Go code labels Apr 28, 2025
@YuryLysov YuryLysov self-assigned this Apr 28, 2025
@YuryLysov YuryLysov force-pushed the dhctl-native-ssh-client branch 6 times, most recently from d3dbd25 to 0268f9d Compare April 30, 2025 07:32
@YuryLysov YuryLysov added the e2e/run/gcp Run e2e tests in Google Cloud label Apr 30, 2025
@deckhouse-BOaTswain
Copy link
Collaborator
deckhouse-BOaTswain commented Apr 30, 2025 •
edited
Loading

🟢 e2e: GCP for deckhouse:dhctl-native-ssh-client succeeded in 49m50s.

Workflow details

GCP-WithoutNAT-Containerd-1.30 - Connection string: ssh user@35.246.242.227

🟢 e2e: GCP, Containerd, Kubernetes 1.30 succeeded in 48m41s.

@github-actions github-actions bot removed the e2e/run/gcp Run e2e tests in Google Cloud label Apr 30, 2025
YuryLysov added 4 commits May 15, 2025 09:44
@YuryLysov
Implement native ssh client
ca4f204 
Signed-off-by: YuryLysov <yuriy.lysov@flant.com>
@YuryLysov
Fix multimaster destroy
8de831d 
Signed-off-by: YuryLysov <yuriy.lysov@flant.com>
@YuryLysov
Fix converge migration command
cb7e382 
Signed-off-by: YuryLysov <yuriy.lysov@flant.com>
@YuryLysov
Fix delete of NodeUser
e142e08 
Signed-off-by: YuryLysov <yuriy.lysov@flant.com>
@YuryLysov YuryLysov force-pushed the dhctl-native-ssh-client branch from ced5e79 to e142e08 Compare May 15, 2025 05:44
YuryLysov added 2 commits May 15, 2025 09:44
@YuryLysov
Fix
0874ebc 
Signed-off-by: YuryLysov <yuriy.lysov@flant.com>
@YuryLysov
Add defered removing of d8-dhctl-converger user by static node cleanup
00501d9 
Signed-off-by: YuryLysov <yuriy.lysov@flant.com>
@YuryLysov YuryLysov marked this pull request as ready for review May 15, 2025 11:05
@z9r5 z9r5 changed the title [dhctl] Implement native ssh client [dhctl] Implement native SSH client May 15, 2025
@YuryLysov
Fix multimaster static destroy through bastion
6a83e10 
Signed-off-by: YuryLysov <yuriy.lysov@flant.com>
@raabdullaev raabdullaev modified the milestones: v1.70.0, v1.71.0 May 21, 2025
YuryLysov added 3 commits May 21, 2025 16:47
@YuryLysov
Update bootstrap
0e5fb5b 
Signed-off-by: YuryLysov <yuriy.lysov@flant.com>
@YuryLysov
Fix panic
bed0172 
Signed-off-by: YuryLysov <yuriy.lysov@flant.com>
@YuryLysov
Update server bootstrap
6427366 
Signed-off-by: YuryLysov <yuriy.lysov@flant.com>
@name212 name212 mentioned this pull request May 22, 2025
Closed
2 tasks
YuryLysov added 3 commits May 28, 2025 19:10
@YuryLysov
Fix context handling
e2b271d 
Signed-off-by: YuryLysov <yuriy.lysov@flant.com>
@YuryLysov
Add sshClient.Start to destroy
a6423ac 
Signed-off-by: YuryLysov <yuriy.lysov@flant.com>
@YuryLysov
Update abort
86eb36c 
Signed-off-by: YuryLysov <yuriy.lysov@flant.com>
@sprait sprait marked this pull request as draft June 4, 2025 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@z9r5 z9r5 z9r5 approved these changes

@nabokihms nabokihms Awaiting requested review from nabokihms nabokihms is a code owner

@name212 name212 Awaiting requested review from name212 name212 is a code owner

@sprait sprait Awaiting requested review from sprait sprait is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

@YuryLysov YuryLysov

Labels
area/cli Pull requests that update cli area/cluster-and-infrastructure Pull requests that update infra modules area/core Pull requests that update core modules go Pull requests that update Go code type/dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
v1.71.0
Development

Successfully merging this pull request may close these issues.
4 participants
@YuryLysov @deckhouse-BOaTswain @z9r5 @raabdullaev
0