8000 [registrypackages] return shim-runc-v1 by sprait · Pull Request #13541 · deckhouse/deckhouse · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[registrypackages] return shim-runc-v1 #13541

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 20, 2025
Merged

[registrypackages] return shim-runc-v1 #13541

merged 2 commits into from
May 20, 2025

Conversation

sprait
Copy link
Member
@sprait sprait commented May 20, 2025 •
edited
Loading

Description

Return shim-runc-v1 for backward compatibility.
Update docs for using shim-runc-v2 in ngc for GPU.

Why do we need it, and what problem does it solve?

Related to #13205 .
shim-runc-v1 was specified in the NGC example for GPU nodes in our documentation.
Need to return shim-runc-v1 to registrypackages for backward compatibility.

Checklist

  • The code is covered by unit tests.
  • e2e tests passed.
  • Documentation updated according to the changes.
  • Changes were tested in the Kubernetes cluster manually.

Changelog entries

section: candi, docs
type: fix
summary: Return `shim-runc-v1` for backward compatibility. 
impact_level: low

@sprait
[registrypackages] return shim-runc-v1
ddbf218 
Signed-off-by: Nikolay Gorbatov <nikolay.gorbatov@flant.com>
@sprait sprait self-assigned this May 20, 2025
@github-actions github-actions bot added area/docs Pull requests that update doumentation area/core Pull requests that update core modules labels May 20, 2025
@sprait
+
22d6fc2 
Signed-off-by: Nikolay Gorbatov <nikolay.gorbatov@flant.com>
@github-actions github-actions bot added the area/cluster-and-infrastructure Pull requests that update infra modules label May 20, 2025
@sprait sprait added this to the v1.70.0 milestone May 20, 2025
@sprait sprait added skip/documentation-validation Skip documentation validation in pull request skip/e2e Skip running e2e test for pass pull request check labels May 20, 2025
@sprait sprait marked this pull request as ready for review May 20, 2025 11:20
@z9r5 z9r5 merged commit 44cd3f5 into main May 20, 2025
92 of 100 checks passed
@z9r5 z9r5 deleted the containerd-return-shim-runc-v1 branch May 20, 2025 11:31
@deckhouse-BOaTswain deckhouse-BOaTswain mentioned this pull request May 20, 2025
Closed
YuryLysov pushed a commit that referenced this pull request May 30, 2025
@sprait @YuryLysov
[registrypackages] return shim-runc-v1 (#13541)
0e7ea57 
Signed-off-by: Nikolay Gorbatov <nikolay.gorbatov@flant.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@z9r5 z9r5 z9r5 approved these changes

@RomanenkoDenys RomanenkoDenys Awaiting requested review from RomanenkoDenys RomanenkoDenys is a code owner

@name212 name212 Awaiting requested review from name212 name212 is a code owner

Assignees

@sprait sprait

Labels
area/cluster-and-infrastructure Pull requests that update infra modules area/core Pull requests that update core modules area/docs Pull requests that update doumentation skip/documentation-validation Skip documentation validation in pull request skip/e2e Skip running e2e test for pass pull request check
Projects
None yet
Milestone
v1.70.0
Development

Successfully merging this pull request may close these issues.
2 participants
@sprait @z9r5
0