8000 [etcd] 3.5.21 by borg-z · Pull Request #13581 · deckhouse/deckhouse · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[etcd] 3.5.21 #13581

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 22, 2025
Merged

[etcd] 3.5.21 #13581

merged 1 commit into from
May 22, 2025

Conversation

borg-z
Copy link
Member
@borg-z borg-z commented May 22, 2025 •
edited by denmaloyreb
Loading

Description

fix etcd-io/etcd#19406 Performance regression in etcd v3.5.16

single-master bootstrap:

kubectl -n kube-system exec -it etcd-candi-15186492990-1-con-1-30-master-0 -- etcd --version
etcd Version: 3.5.21
Git SHA: Not provided (use ./build instead of go build)
Go Version: go1.24.2
Go OS/Arch: linux/amd64

multi-master upgrade:

+-------------------------+------------------+---------+---------+-----------+------------+-----------+------------+--------------------+--------+
|        ENDPOINT         |        ID        | VERSION | DB SIZE | IS LEADER | IS LEARNER | RAFT TERM | RAFT INDEX | RAFT APPLIED INDEX | ERRORS |
+-------------------------+------------------+---------+---------+-----------+------------+-----------+------------+--------------------+--------+
| https://10.14.0.11:2379 | 2da7a0b3e7a840fd |  3.5.17 |  246 MB |     false |      false |        25 |   35939828 |           35939828 |        |
| https://10.14.0.10:2379 | 6af3d7895bbf5d81 |  3.5.17 |  217 MB |      true |      false |        25 |   35939835 |           35939835 |        |
| https://10.14.0.12:2379 | bbce13487be483bc |  3.5.17 |  221 MB |     false |      false |        25 |   35939835 |           35939835 |        |
+-------------------------+------------------+---------+---------+-----------+------------+-----------+------------+--------------------+--------+


+-------------------------+------------------+---------+---------+-----------+------------+-----------+------------+--------------------+--------+
|        ENDPOINT         |        ID        | VERSION | DB SIZE | IS LEADER | IS LEARNER | RAFT TERM | RAFT INDEX | RAFT APPLIED INDEX | ERRORS |
+-------------------------+------------------+---------+---------+-----------+------------+-----------+------------+--------------------+--------+
| https://10.14.0.11:2379 | 2da7a0b3e7a840fd |  3.5.17 |  246 MB |     false |      false |        25 |   35941943 |           35941943 |        |
| https://10.14.0.10:2379 | 6af3d7895bbf5d81 |  3.5.17 |  217 MB |      true |      false |        25 |   35941944 |           35941944 |        |
| https://10.14.0.12:2379 | bbce13487be483bc |  3.5.21 |  221 MB |     false |      false |        25 |   35941944 |           35941944 |        |
+-------------------------+------------------+---------+---------+-----------+------------+-----------+------------+--------------------+--------+

+-------------------------+------------------+---------+---------+-----------+------------+-----------+------------+--------------------+--------+
|        ENDPOINT         |        ID        | VERSION | DB SIZE | IS LEADER | IS LEARNER | RAFT TERM | RAFT INDEX | RAFT APPLIED INDEX | ERRORS |
+-------------------------+------------------+---------+---------+-----------+------------+-----------+------------+--------------------+--------+
| https://10.14.0.11:2379 | 2da7a0b3e7a840fd |  3.5.17 |  246 MB |      true |      false |        26 |   35943086 |           35943086 |        |
| https://10.14.0.10:2379 | 6af3d7895bbf5d81 |  3.5.21 |  217 MB |     false |      false |        26 |   35943086 |           35943085 |        |
| https://10.14.0.12:2379 | bbce13487be483bc |  3.5.21 |  221 MB |     false |      false |        26 |   35943090 |           35943086 |        |
+-------------------------+------------------+---------+---------+-----------+------------+-----------+------------+--------------------+--------+

+-------------------------+------------------+---------+---------+-----------+------------+-----------+------------+--------------------+--------+
|        ENDPOINT         |        ID        | VERSION | DB SIZE | IS LEADER | IS LEARNER | RAFT TERM | RAFT INDEX | RAFT APPLIED INDEX | ERRORS |
+-------------------------+------------------+---------+---------+-----------+------------+-----------+------------+--------------------+--------+
| https://10.14.0.11:2379 | 2da7a0b3e7a840fd |  3.5.21 |  246 MB |     false |      false |        27 |   35945013 |           35945013 |        |
| https://10.14.0.10:2379 | 6af3d7895bbf5d81 |  3.5.21 |  217 MB |     false |      false |        27 |   35945014 |           35945014 |        |
| https://10.14.0.12:2379 | bbce13487be483bc |  3.5.21 |  221 MB |      true |      false |        27 |   35945014 |           35945014 |        |
+-------------------------+------------------+---------+---------+-----------+------------+-----------+------------+--------------------+--------+

Why do we need it, and what problem does it solve?

Performance regression in etcd v3.5.16

Why do we need it in the patch release (if we do)?

In version 3.5.16, there are performance issues. We are periodically receiving reports about these problems from clients.

Checklist

  • The code is covered by unit tests.
  • e2e tests passed.
  • Documentation updated according to the changes.
  • Changes were tested in the Kubernetes cluster manually.

Changelog entries

section: control-plane-manager
type: fix
summary: Fixed performance regression in `etcd`.
impact:
impact_level: default

@borg-z
++
3c15a18 
Signed-off-by: borg-z <me@nikolay-z.top>
@github-actions github-actions bot added the area/cluster-and-infrastructure Pull requests that update infra modules label May 22, 2025
@borg-z borg-z added the e2e/run/static Run e2e tests for static cluster label May 22, 2025
@deckhouse-BOaTswain
Copy link
Collaborator
deckhouse-BOaTswain commented May 22, 2025 •
edited
Loading

🔴 e2e: Static for deckhouse:etcd-3.5.21 failed in 36m31s.

E2e for static Static;containerd;1.30 was failed. Use:
ssh -i ~/.ssh/e2e-id-rsa -J astra@46.161.53.66 astra@192.168.199.95 - connect for debugging;

/e2e/abort static;Static;containerd;1.30 15186492990 15186492990-1-con-1-30 /sys/deckhouse-oss/install:pr13581 astra@192.168.199.95 - for abort failed cluster

Workflow details (1 job failed)

Static-Static-Containerd-1.30 - Connection string: ssh -J astra@46.161.53.66 astra@192.168.199.95

🔴 e2e: Static, Containerd, Kubernetes 1.30 failed in 35m24s.

@github-actions github-actions bot removed the e2e/run/static Run e2e tests for static cluster label May 22, 2025
@borg-z borg-z added this to the v1.70.0 milestone May 22, 2025
@deckhouse-BOaTswain deckhouse-BOaTswain added the e2e/cluster/failed Pull request contains failed e2e cluster label May 22, 2025
@borg-z
Copy link
Member Author
borg-z commented May 22, 2025

/e2e/abort static;Static;containerd;1.30 15186492990 15186492990-1-con-1-30 /sys/deckhouse-oss/install:pr13581 astra@192.168.199.95

@borg-z borg-z added the e2e/run/yandex-cloud Run e2e tests in Yandex Cloud label May 22, 2025
@deckhouse-BOaTswain
Copy link
Collaborator
deckhouse-BOaTswain commented May 22, 2025 •
edited
Loading

🟢 destroy cluster: Static for refs/heads/main succeeded in 2m49s.

Workflow details

🟢 destroy cluster: Static, Containerd, Kubernetes 1.30 succeeded in 2m27s.

@deckhouse-BOaTswain
Copy link
Collaborator
deckhouse-BOaTswain commented May 22, 2025 •
edited
Loading

🟢 e2e: Yandex.Cloud for deckhouse:etcd-3.5.21 succeeded in 39m12s.

Workflow details

Yandex.Cloud-WithoutNAT-Containerd-1.30 - Connection string: ssh redos@51.250.15.253

🟢 e2e: Yandex.Cloud, Containerd, Kubernetes 1.30 succeeded in 38m11s.

@github-actions github-actions bot removed the e2e/run/yandex-cloud Run e2e tests in Yandex Cloud label May 22, 2025
@borg-z borg-z removed the e2e/cluster/failed Pull request contains failed e2e cluster label May 22, 2025
@Steamvis Steamvis modified the milestones: v1.70.0, v1.71.0 May 22, 2025
@borg-z borg-z added the e2e/run/static Run e2e tests for static cluster label May 22, 2025
@borg-z borg-z marked this pull request as ready for review May 22, 2025 13:42
@borg-z borg-z requested review from name212 and sprait as code owners May 22, 2025 13:42
@deckhouse-BOaTswain
Copy link
Collaborator
deckhouse-BOaTswain commented May 22, 2025 •
edited
Loading

🟢 e2e: Static for deckhouse:etcd-3.5.21 succeeded in 31m37s.

Workflow details

Static-Static-Containerd-1.30 - Connection string: ssh -J astra@87.228.90.129 astra@192.168.199.62

🟢 e2e: Static, Containerd, Kubernetes 1.30 succeeded in 30m22s.

@github-actions github-actions bot removed the e2e/run/static Run e2e tests for static cluster label May 22, 2025
@name212 name212 modified the milestones: v1.71.0, v1.70.0 May 22, 2025
@name212 name212 added the status/backport Cherry-pick PR to the release branch from the Milestone label May 22, 2025
@name212 name212 merged commit 9abd1cc into main May 22, 2025
116 of 138 checks passed
@name212 name212 deleted the etcd-3.5.21 branch May 22, 2025 15:59
github-actions bot pushed a commit that referenced this pull request May 22, 2025
@borg-z @name212
[etcd] 3.5.21 (#13581)
ca69f0c 
Signed-off-by: borg-z <me@nikolay-z.top>
@deckhouse-BOaTswain deckhouse-BOaTswain removed the status/backport Cherry-pick PR to the release branch from the Milestone label May 22, 2025
deckhouse-BOaTswain added a commit that referenced this pull request May 22, 2025
@deckhouse-BOaTswain @borg-z
[etcd] 3.5.21 (#13581) (#13588)
c189a48 
Signed-off-by: borg-z <me@nikolay-z.top>
Co-authored-by: Nikolay Zykov <me@nikolay-z.top>
@deckhouse-BOaTswain
Copy link
Collaborator

Cherry pick PR 13588 to the branch release-1.70 successful!

@deckhouse-BOaTswain deckhouse-BOaTswain mentioned this pull request May 22, 2025
Open
RottenRat pushed a commit that referenced this pull request May 23, 2025
@borg-z
[etcd] 3.5.21 (#13581)
a6dab25 
Signed-off-by: borg-z <me@nikolay-z.top>
RottenRat pushed a commit that referenced this pull request May 28, 2025
@borg-z
[etcd] 3.5.21 (#13581)
71d089d 
Signed-off-by: borg-z <me@nikolay-z.top>
YuryLysov pushed a commit that referenced this pull request May 30, 2025
@borg-z @YuryLysov
[etcd] 3.5.21 (#13581)
98ddb41 
Signed-off-by: borg-z <me@nikolay-z.top>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@name212 name212 name212 approved these changes

@sprait sprait Awaiting requested review from sprait sprait is a code owner

Assignees

@borg-z borg-z

Labels
area/cluster-and-infrastructure Pull requests that update infra modules status/backport/success
Projects
None yet
Milestone
v1.70.0
Development

Successfully merging this pull request may close these issues.

Performance regression in etcd v3.5.16
4 participants
@borg-z @deckhouse-BOaTswain @name212 @Steamvis
0