8000 Backport: [metallb] fix CRD addresspools.metallb.io deletion by deckhouse-BOaTswain · Pull Request #13592 · deckhouse/deckhouse · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Backport: [metallb] fix CRD addresspools.metallb.io deletion #13592

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 22, 2025
Merged

Backport: [metallb] fix CRD addresspools.metallb.io deletion #13592

merged 1 commit into from
May 22, 2025

Conversation

deckhouse-BOaTswain
Copy link
Collaborator

Description

Move the global hook to remove CRD addresspools.metallb.io to the d8-metallb module.

Why do we need it, and what problem does it solve?

PR #12453 implements the removal of the addresspools.metallb.io CRD. But if the customer uses its own metallb module, the hook removes its CRD too. Now hook removes CRD only when d8-metallb module is enabled.

Why do we need it in the patch release (if we do)?

The problem affects CE edition users after upgrading to version 1.69.

Checklist

  • The code is covered by unit tests.
  • e2e tests passed.
  • Documentation updated according to the changes.
  • Changes were tested in the Kubernetes cluster manually.

Changelog entries

section: metallb
type: fix
summary: Fixed deprecated CRD addresspools.metallb.io deletion.

@tarabrind @saribaev021
[metallb] fix CRD addresspools.metallb.io deleteon (#13553)
03b22dd 
Signed-off-by: Denis Tarabrin <denis.tarabrin@flant.com>
@deckhouse-BOaTswain deckhouse-BOaTswain merged commit 9a3ce92 into release-1.69 May 22, 2025
@deckhouse-BOaTswain deckhouse-BOaTswain deleted the cherry-pick-release-1.69-daa76bb31ec82edaac7d2df379a71755889a3c8f branch May 22, 2025 16:58
@deckhouse-BOaTswain deckhouse-BOaTswain mentioned this pull request May 22, 2025
Merged
4 tasks
@github-actions github-actions bot added the go Pull requests that update Go code label May 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@apolovov apolovov Awaiting requested review from apolovov apolovov is a code owner

Assignees

@deckhouse-BOaTswain deckhouse-BOaTswain

Labels
auto backported go Pull requests that update Go code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@deckhouse-BOaTswain @tarabrind
0