mm: Fix balance handling for shared txs across matches #3138
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The balance handling was incorrectly handling situations where multiple matches in the same order shared a swap or redemption transaction. For example if there were three matches which redeemed 1 DCR each using the same transaction, the balance handling would think that 9 DCR was redeemed instead of 3.
JoeGruffins
approved these changes
Jan 10, 2025
martonp
added a commit
to martonp/dcrdex
that referenced
this pull request
Feb 6, 2025
The balance handling was incorrectly handling situations where multiple matches in the same order shared a swap or redemption transaction. For example if there were three matches which redeemed 1 DCR each using the same transaction, the balance handling would think that 9 DCR was redeemed instead of 3.
buck54321
pushed a commit
to buck54321/dcrdex
that referenced
this pull request
Feb 25, 2025
The balance handling was incorrectly handling situations where multiple matches in the same order shared a swap or redemption transaction. For example if there were three matches which redeemed 1 DCR each using the same transaction, the balance handling would think that 9 DCR was redeemed instead of 3.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The balance handling was incorrectly handling situations where multiple matches in the same order shared a swap or redemption transaction. For example if there were three matches which redeemed 1 DCR each using the same transaction, the balance handling would think that 9 DCR was redeemed instead of 3.