eth/pol: Gasless redemptions using account abstraction #3175
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- **Overview:**
- Uses ERC-4337 for account abstraction in gasless
redemptions.
- Users can now perform gasless redemptions by
specifying a bundler endpoint in wallet settings.
- If insufficient balance, redemption transactions
are handled via user operations sent to the bundler,
which then submits to the network and takes a fee.
- **Changes in `dex/networks/eth`:**
- Updated V1 ETH swap contract to support account
abstraction via the `IAccount` interface.
- Added functions:
- `validateUserOp`: Validates user operations and
prepays gas for redemption.
- `redeemAA`: Executes the redemption.
- **Changes in `client/asset/eth`:**
- `ReserveNRedemptions` updated to return 0 without
error if there is insufficient funds for redemption,
but a bundler is configured.
- Added `GaslessRedeem` function for bundler-based
redemptions when `ReserveNRedemptions` returns 0.
- Updated `txDB` to order transactions by timestamp
instead of nonce, now using lexi instead of raw
badgerDB.
- Added logic to keep track of pending user
operations, and confirming redemptions done using
account abstraction.
- **Changes in `client/core`:**
- Calling `GaslessRedeem` instead of `Redeem` if
`ReserveNRedemptions` returns 0.
- Post-redeem actions:
- For `Redeem`, immediately sends a redeem message
to the server.
- For `GaslessRedeem`, waits for `ConfirmRedemption`
to ensure submission before messaging the server
with the updated coin ID (now includes both user
op ID and tx hash).
- **Changes in `server/asset/eth`:**
- Added support for validating redemptions submitted
by a bundler. The bundler must have submitted a
transaction before the server is notified.
- **Changes in `server/market`:**
- Update balance checking for redemptions of EVM base
assets to no longer require a balance. Token
redemptions still require a balance.
# Conflicts:
# dex/lexi/table.go
# dex/networks/eth/tokens.go
# dex/testing/eth/harness.sh
# dex/testing/polygon/harness.sh
eb2c555 to
755da6e
Compare
|
This all looks very reasonable. Love that lexi upgrade. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview:
Changes in
dex/networks/eth:IAccountinterface.validateUserOp: Validates user operations and prepays gas for redemption.redeemAA: Executes the redemption.Changes in
client/asset/eth:ReserveNRedemptionsupdated to return 0 without error if there is insufficient funds for redemption, but a bundler is configured.GaslessRedeemfunction for bundler-based redemptions whenReserveNRedemptionsreturns 0.txDBto order transactions by timestampinstead of nonce, now using lexi instead of raw badgerDB.
Changes in
client/core:GaslessRedeeminstead ofRedeemifReserveNRedemptionsreturns 0.Redeem, immediately sends a redeem message to the server.GaslessRedeem, waits forConfirmRedemptionto ensure submission before messaging the server with the updated coin ID (now includes both user op ID and tx hash).Changes in
server/asset/eth:Changes in
server/market:I have tested using Alchemy on testnet, and it works well. I have also tested with Pimlico, but there are some issues. I'm in contact with their support to resolve them. I will keep testing other bundler providers.