8000 ci: disable caching on Windows tests by anakin87 · Pull Request #9318 · deepset-ai/haystack · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

ci: disable caching on Windows tests #9318

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Apr 29, 2025
Merged

ci: disable caching on Windows tests #9318

merged 4 commits into from
Apr 29, 2025

Conversation

anakin87
Copy link
Member
@anakin87 anakin87 commented Apr 28, 2025 •
edited
Loading

Related Issues

Proposed Changes:

  • disable caching on Windows tests

How did you test it?

CI - triggered tests in c33c2dd

CI Runtime Comparison

Non-Windows test times are included for context but are unaffected by the Windows caching configuration.

Test With Windows Cache Without Windows Cache
Unit / windows-latest 5m 2s 4m 58s
Integration / windows-latest 6m 11s 3m 24s
Integration / ubuntu-latest 2m 7s (not impacted) 2m 0s (not impacted)
Integration / macos-latest 2m 12s (not impacted) 1m 51s (not impacted)
Total tests workflow duration 12m 8s 9m 12s

Although the root cause of the cache slowdown on Windows is still unclear (investigation in #9319), disabling it offers two benefits:

  • Significant runtime improvement in Integration / windows-latest job (slowest job in tests).
  • While not visible in the table, saving the cache in Unit / windows-latest requires about 15s. Skipping this allows integration tests start sooner.

Notes for the reviewer

Over time, we should evaluate if it's worth re-enabling cache.

@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 14712345305

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 90.5%
Totals Coverage Status
Change from base Build 14709162118: 0.0%
Covered Lines: 10879
Relevant Lines: 12021
💛 - Coveralls

@anakin87 anakin87 changed the title ci: try skipping cache on Windows ci: disable caching on Windows tests Apr 29, 2025
@anakin87 anakin87 marked this pull request as ready for review April 29, 2025 10:01
@anakin87 anakin87 requested a review from a team as a code owner April 29, 2025 10:01
@anakin87 anakin87 requested review from mpangrazzi and davidsbatista and removed request for a team April 29, 2025 10:01
davidsbatista
davidsbatista approved these changes Apr 29, 2025
View reviewed changes
Copy link
Contributor
@davidsbatista davidsbatista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@davidsbatista davidsbatista merged commit f8eead3 into main Apr 29, 2025
9 checks passed
@davidsbatista davidsbatista deleted the ci-skip-windows-caching branch April 29, 2025 16:21
@anakin87 anakin87 mentioned this pull request Apr 29, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidsbatista davidsbatista davidsbatista approved these changes

@mpangrazzi mpangrazzi Awaiting requested review from mpangrazzi mpangrazzi is a code owner automatically assigned from deepset-ai/open-source-engineering

Assignees
No one assigned
Labels
topic:build/distribution topic:CI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@anakin87 @coveralls @davidsbatista
0