8000 fix(grafana): Redis cpu graph was not selecting right data by jchauncey · Pull Request #126 · deis/monitor · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix(grafana): Redis cpu graph was not selecting right data #126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 20, 2016
Merged

fix(grafana): Redis cpu graph was not selecting right data #126

merged 1 commit into from
Jul 20, 2016

Conversation

jchauncey
Copy link
Member
@jchauncey jchauncey commented Jul 20, 2016 •
edited
Loading

Testing steps:

  1. Checkout pr
  2. run make build push in grafana directory
  3. login grafana.mydomain.com - admin/admin
  4. Make sure the Redis CPU graph is reporting normal metric levels (just a few milliseconds of cpu usage not hours).

@jchauncey jchauncey added this to the v2.2 milestone Jul 20, 2016
@jchauncey jchauncey self-assigned this Jul 20, 2016
@krancour
Copy link
Contributor

Too hard to review these wholesale JSON changes... so I tested with on-cluster and off-cluster Redis and see what I expected. With off-cluster, CPU graph shows nothing, with on-cluster CPU graph shows usage that looks pretty similar to the ops/second graph-- a good sign that it's correct now. 👍

@mboersma
Copy link
Member

Redis CPU graph looks sane here after testing. 👍

@jchauncey jchauncey merged commit 7dd5da8 into deis:master Jul 20, 2016
@jchauncey jchauncey deleted the fix-redis-cpu branch August 25, 2016 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jchauncey jchauncey

Labels
LGTM1 LGTM2 needs manual testing showstopper
Projects
None yet
Milestone
v2.2
Development

Successfully merging this pull request may close these issues.
3 participants
@jchauncey @krancour @mboersma
0