LogsignSiem Pack PR #14565
Merged
LogsignSiem Pack PR #14565
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* created logsignsiem pack * added logsignsiem classifiers mapper files and deleted dockerfile * fixed [PA126] validation warning * fixed some description in yaml file * deleted override http_request method and updated unittests * fixed last_fetch parameter and updated tests * removed unused variable * fixed logsignsiem api description * fixed logsignsiem api description * added query parameter and help section and fixed get-columns-query on api * fixed unittest func name * fixed Flake8 error * Update Packs/LogsignSiem/README.md * deleted logsign-get-incident method, added default param to query * rm integration setup from detailed desc * set default classifier and mapper Co-authored-by: Itay Keren <ikeren@paloaltonetworks.com>
|
The CircleCI check from your latest pushed commit was unsuccessful. @content-bot take a look at the build by clicking this link. Failed Build Steps
Try and address the listed CircleCI build step failures at your earliest convenience. This will greatly expedite the process of getting your proposed changes merged into master. Happy coding and may the force be with you. |
Itay4
approved these changes
Aug 29, 2021
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original External PR
external pull request
Contributor
@keremvatandas
Contributing to Cortex XSOAR Content
Make sure to register your contribution by filling the contribution registration form
The Pull Request will be reviewed only after the contribution registration form is filled.
Status
Description
A few sentences describing the overall goals of the pull request's commits.
Screenshots
Paste here any images that will help the reviewer
Minimum version of Cortex XSOAR
Does it break backward compatibility?
Must have