Http bytes save file #1161
Merged
Http bytes save file #1161
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Itay4
reviewed
Jan 17, 2018
| 'moloch_sessions_pcap': 'sessions.pcap', | ||
| 'moloch_spigraph_json': 'spigraph.json', | ||
| 'moloch_spiview_json': 'spiview.json', | ||
| 'moloch_unique_json': 'unique.txt', |
| var urlDict = { | ||
| 'moloch_connections_json': 'connections.json', | ||
| 'moloch_connections_csv': 'connections.csv', | ||
| 'moloch_files_json': 'files.json', |
There was a problem hiding this comment.
files.json doesn't seem to work, should be file/list
| @@ -43,7 +43,7 @@ script: | |||
| if (res.StatusCode < 200 || res.StatusCode >= 300) { | |||
| throw 'Failed to ' + queryName + ', request status code: ' + res.StatusCode + ' and Body: ' + res.Body + '.'; | |||
| } | |||
| return res.Body; | |||
| return res; | |||
| } | |||
|
|
|||
| var urlDict = { | |||
There was a problem hiding this comment.
Unnecessary comma
files.json should be file/list
| @@ -0,0 +1,528 @@ | |||
| commonfields: | |||
| id: Check Point Sandblast | |||
There was a problem hiding this comment.
Should do the same changes to Check Point Sandblast Appliance
Integrations/integration-Zendesk.yml
Outdated
| @@ -900,3 +900,5 @@ script: | |||
| description: Locale. Defaults to en-us | |||
| description: Get Zendesk Help Center article | |||
| isfetch: true | |||
| releaseNotes: "Added zendesk-add-user for adding end users. Added zendesk-get-article to get help center article" | |||
There was a problem hiding this comment.
Shouldn't be empty release notes?
9054ddd to
b54b8db
Compare
…-bytes-save-file :wq
Itay4
approved these changes
Jan 17, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@aviadl please assign someone to review the changes (and do some tests)