8000 Fix timestamp conversion error by yaakovpraisler · Pull Request #13437 · demisto/content · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix timestamp conversion error #13437

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 17 commits into from
Jul 4, 2021

Conversation

yaakovpraisler
Copy link
Contributor

Status

  • In Progress
  • Ready
  • In Hold - (Reason for hold)

Related Issues

fixes: https://github.com/demisto/etc/issues/38629

Description

Fix timestamp conversion error in CSVFeed.

Minimum version of Cortex XSOAR

  • 5.5.0
  • 6.0.0
  • 6.1.0
  • 6.2.0

Does it break backward compatibility?

  • Yes
    • Further details:
  • No

Must have

  • Tests
  • Documentation

@yaakovpraisler yaakovpraisler requested a review from roysagi June 28, 2021 11:02
@lgtm-com
Copy link
lgtm-com bot commented Jun 28, 2021

This pull request introduces 1 alert when merging c45d000 into 061083b - view on LGTM.com

new alerts:

  • 1 for Unused import

@lgtm-com
Copy link
lgtm-com bot commented Jun 28, 2021

This pull request introduces 1 alert when merging 8567fbf into 5f73e7c - view on LGTM.com

new alerts:

  • 1 for Unused import

@lgtm-com
Copy link
lgtm-com bot commented Jun 29, 2021

This pull request introduces 1 alert when merging c2dfefc into a44c232 - view on LGTM.com

new alerts:

  • 1 for Unused import

Copy link
Contributor
@roysagi roysagi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a unit test and please test that this feed still works after the change.

@lgtm-com
Copy link
lgtm-com bot commented Jun 30, 2021

This pull request introduces 1 alert when merging aaa027e into f3361b1 - view on LGTM.com

new alerts:

  • 1 for Unused import

@lgtm-com
Copy link
lgtm-com bot commented Jul 1, 2021

This pull request introduces 1 alert when merging 60b411b into c6808d0 - view on LGTM.com

new alerts:

  • 1 for Unused import

@yaakovpraisler yaakovpraisler requested a review from roysagi July 1, 2021 07:41
yaakovpraisler and others added 8 commits July 4, 2021 13:35
Co-authored-by: roysagi <50295826+roysagi@users.noreply.github.com>
Co-authored-by: roysagi <50295826+roysagi@users.noreply.github.com>
Co-authored-by: roysagi <50295826+roysagi@users.noreply.github.com>
Co-authored-by: roysagi <50295826+roysagi@users.noreply.github.com>
Co-authored-by: roysagi <50295826+roysagi@users.noreply.github.com>
Co-authored-by: roysagi <50295826+roysagi@users.noreply.github.com>
Co-authored-by: roysagi <50295826+roysagi@users.noreply.github.com>
@yaakovpraisler yaakovpraisler merged commit 74720f7 into master Jul 4, 2021
@yaakovpraisler yaakovpraisler deleted the Fix_timestamp_conversion_error_in_CSVFee branch July 4, 2021 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0