Jwilkes tenable #22548
Merged
Jwilkes tenable #22548
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your contribution. Your generosity and caring are unrivaled! Make sure to register your contribution by filling the Contribution Registration form, so our content wizard @omerKarkKatz will know he can start review the proposed changes. |
There was a problem hiding this comment.
Hey @johnnywilkes, thanks a lot for your contribution looks great.
I added some comments and suggestions below please look at them and fix accordingly.
If you have any further questions you can feel free to reach out here or by slack.
When you finish let me know and we will schedule a short demo on your contribution. Thanks a lot!
| @@ -357,6 +360,20 @@ def send_asset_vuln_request(asset_id, date_range): | |||
| return res.json() | |||
|
|
|||
|
|
|||
| def send_asset_details_request(asset_id): | |||
There was a problem hiding this comment.
please add python doc string to the function on all functions below. doc string .
Also please add type annotation to the functions.
There was a problem hiding this comment.
@omerKarkKatz , none of the other function have doc strings. Do you still want me to add? (not a problem either way)
There was a problem hiding this comment.
added anyways, this should be resolved
Co-authored-by: omerKarkKatz <95565843+omerKarkKatz@users.noreply.github.com>
|
This pull request introduces 1 alert when merging d77e813 into 19609b2 - view on LGTM.com new alerts:
Heads-up: LGTM.com's PR analysis will be disabled on the 5th of December, and LGTM.com will be shut down ⏻ completely on the 16th of December 2022. Please enable GitHub code scanning, which uses the same CodeQL engine ⚙️ that powers LGTM.com. For more information, please check out our post on the GitHub blog. |
|
@omerKarkKatz , I added types and docstrings, let me know if that works for you |
Co-authored-by: omerKarkKatz <95565843+omerKarkKatz@users.noreply.github.com>
omerKarkKatz
approved these changes
Nov 30, 2022
omerKarkKatz
added a commit
that referenced
this pull request
Dec 1, 2022
* Jwilkes tenable (#22548) * EXPANDR-89 - init * unit test first draft * more unit test work * finished unit tests * format and removed comments * updated integration README * rel notes * Apply suggestions from code review Co-authored-by: omerKarkKatz <95565843+omerKarkKatz@users.noreply.github.com> * bug fix, docstring, types * fixed flake errors * Update Packs/Tenable_io/Integrations/Tenable_io/Tenable_io.py Co-authored-by: omerKarkKatz <95565843+omerKarkKatz@users.noreply.github.com> * Update Packs/Tenable_io/Integrations/Tenable_io/Tenable_io.yml * update docker image Co-authored-by: omerKarkKatz <95565843+omerKarkKatz@users.noreply.github.com> * Update Packs/Tenable_io/ReleaseNotes/2_1_0.md Co-authored-by: johnnywilkes <32227961+johnnywilkes@users.noreply.github.com> Co-authored-by: omerKarkKatz <95565843+omerKarkKatz@users.noreply.github.com>
bakatzir
pushed a commit
that referenced
this pull request
Dec 4, 2022
* Jwilkes tenable (#22548) * EXPANDR-89 - init * unit test first draft * more unit test work * finished unit tests * format and removed comments * updated integration README * rel notes * Apply suggestions from code review Co-authored-by: omerKarkKatz <95565843+omerKarkKatz@users.noreply.github.com> * bug fix, docstring, types * fixed flake errors * Update Packs/Tenable_io/Integrations/Tenable_io/Tenable_io.py Co-authored-by: omerKarkKatz <95565843+omerKarkKatz@users.noreply.github.com> * Update Packs/Tenable_io/Integrations/Tenable_io/Tenable_io.yml * update docker image Co-authored-by: omerKarkKatz <95565843+omerKarkKatz@users.noreply.github.com> * Update Packs/Tenable_io/ReleaseNotes/2_1_0.md Co-authored-by: johnnywilkes <32227961+johnnywilkes@users.noreply.github.com> Co-authored-by: omerKarkKatz <95565843+omerKarkKatz@users.noreply.github.com>
bakatzir
added a commit
that referenced
this pull request
Dec 18, 2022
* update core packs on MP and MPv2 * rm type * rm redundant comma * Update Tests/Marketplace/core_packs_list.json Co-authored-by: Yaakov Praisler <59408745+yaakovpraisler@users.noreply.github.com> * Update Tests/Marketplace/core_packs_list.json Co-authored-by: Yaakov Praisler <59408745+yaakovpraisler@users.noreply.github.com> * Update Tests/Marketplace/core_packs_list.json * Jwilkes tenable (#22595) * Jwilkes tenable (#22548) * EXPANDR-89 - init * unit test first draft * more unit test work * finished unit tests * format and removed comments * updated integration README * rel notes * Apply suggestions from code review Co-authored-by: omerKarkKatz <95565843+omerKarkKatz@users.noreply.github.com> * bug fix, docstring, types * fixed flake errors * Update Packs/Tenable_io/Integrations/Tenable_io/Tenable_io.py Co-authored-by: omerKarkKatz <95565843+omerKarkKatz@users.noreply.github.com> * Update Packs/Tenable_io/Integrations/Tenable_io/Tenable_io.yml * update docker image Co-authored-by: omerKarkKatz <95565843+omerKarkKatz@users.noreply.github.com> * Update Packs/Tenable_io/ReleaseNotes/2_1_0.md Co-authored-by: johnnywilkes <32227961+johnnywilkes@users.noreply.github.com> Co-authored-by: omerKarkKatz <95565843+omerKarkKatz@users.noreply.github.com> * Validation fix (#22611) * poetry * revert * validations failure fixed * release notes * add_comment_to_approved_categories (#22609) * TIM - fix IP regex in CSP (#22590) * fix IP regex * DOCKER IMAGE * added . * update new regex * XCLOUD Cryptomining (#22402) * test * test * XCLOUD Cryptomining files * update RN * fixes * added incident type+layout * added scripts * docs * fix secrets * fixes * fixes * fixes * incident fields fixes * fixes skipifunavailable * fixes skipifunavailable * fix scripts naming in the layout * added packs readme info * fix png * fix png * fix incident fields * update CommonTypes RN * fixes * fixes * fixes * fixes * Update playbook-Cloud_Response_-_AWS_README.md Done. * Update playbook-Cloud_Response_-_AWS.yml Done. * Update README.md Done. * Update 1_0_1.md Done. * Update playbook-Cloud_Response_-_Azure.yml Done * Update playbook-Cloud_Response_-_AWS.yml Done. * Update playbook-Cloud_Response_-_Azure_README.md Done. * Update README.md Done. * Update playbook-Cloud_Response_-_Generic.yml Done. * Update 2_3_14.md Done. * Update Cortex_XDR_Alerts_Handling.yml Done. * Update Cortex_XDR_Alerts_Handling_README.md Done * Update Cortex_XDR_Alerts_Handling.yml Done. * Update playbook-Account_Enrichment_-_Generic_v2.2.yml Done. * Update Cortex_XDR_incident_handling_v3.yml Done. * Update playbook-Cloud_Cryptomining.yml Done. * Update playbook-Cloud_Cryptomining_README.md Done. * Update playbook-Cloud_Enrichment.yml Done. * Update playbook-Cloud_Enrichment_README.md Done. * Update playbook-Cryptomining_-_Set_Verdict.yml Done. * Update playbook-Cryptomining_-_Set_Verdict_README.md Done. * Update 4_9_4.md Done. * Update playbook-Cloud_Response_-_GCP.yml Done. * Update playbook-Cloud_Response_-_GCP_README.md Done. * Update README.md Done. * fixes * fix * fix readme * fix readme * typos * typos * fix AWS playbook * fix AWS playbook * fix Azure playbook * fix GCP playbook * fix naming and skipifunavailable * added new playbook input "sourceIP" to all sub-playbooks * fix setIfEmpty * fix setIfEmpty * added associated types * changed default playbook * typos * added "systemAssociatedTypes" * added playbook outputs * added playbook outputs * fix img name in readme * fix docker version * update RN * fix * update RN Co-authored-by: evisochek <evisochek@paloaltonetworks.com> Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com> * remove o365 check for pyEWS_Test (#22329) * remove test * add rn * update docket image * replace rn * update docker * update rn * fix rn * fix rn * Remove duplicate mapping from the Modeling rule. (#22583) * Remove duplicate mapping from the Modeling rule. * created releaso notes files * Changed text in the release note. Co-authored-by: Darya Koval <dkoval@paloaltonetworks.com> * ParsingRules Nadav Demo 2 (#22592) * Added Jira ParsingRules * Added Mimecast ParsingRules * Added OktaOAG ParsingRules * Update OktaOAGParsingRules.xif * Update JiraParsingRules.xif * URL formatter returning an output when encountering escape chars at end of url (#22588) * URL Formatter better handling escape chars * URL Formatter better handling escape chars * RN * Update FormatURL.py * unneeded white space. * Update FormatURL.py * Update FormatURL_test.py * Removed lower() from formatter to return a case sensitive URL. * Update 1_10_16.md * Validation fixes. * RN * Update FormatURL_test.py * Updated test playbook with case sensitive URLs * [Marketplace Contribution] Akamai WAF - Content Pack Update (#22614) * [Marketplace Contribution] Akamai WAF - Content Pack Update (#22576) * "contribution update to pack "Akamai WAF"" * Update 2_0_2.md * Update Packs/Akamai_WAF/Integrations/Akamai_WAF/Akamai_WAF.yml Co-authored-by: omerKarkKatz <95565843+omerKarkKatz@users.noreply.github.com> * Update Packs/Akamai_WAF/ReleaseNotes/2_0_2.md Co-authored-by: omerKarkKatz <95565843+omerKarkKatz@users.noreply.github.com> Co-authored-by: Chang Liu <34745025+chang-ing@users.noreply.github.com> Co-authored-by: omerKarkKatz <95565843+omerKarkKatz@users.noreply.github.com> * reverted the description change * Apply suggestions from code review updated release notes * Update Packs/Akamai_WAF/Integrations/Akamai_WAF/Akamai_WAF.yml updated yml docker image Co-authored-by: xsoar-bot <67315154+xsoar-bot@users.noreply.github.com> Co-authored-by: Chang Liu <34745025+chang-ing@users.noreply.github.com> Co-authored-by: omerKarkKatz <95565843+omerKarkKatz@users.noreply.github.com> Co-authored-by: okarkkatz <okarkkatz@paloaltonetworks.com> * Remove correlation rules (#22620) * remove correlation rules * update release notes * fix Alibaba release notes (#22624) * Removed XSIAM Dashboards (#22625) * Removed CyberArkDashboard * Removed Dropbox DropboxDashboard * Removed XSIAMDashboards * Updated ReleaseNotes * Teams docs update (#22426) * added some documentation * added some documentation * added rn * added tutorial video * updated docker image * updated docker image * removed condition where failed preview image fails the entire list. (#22627) * removed condition where failed preview image fails the entire list. Fixed the case where deleted preview image is failing a single ack * fix function renaming * Fix pack collection conditions * Revert "Fix pack collection conditions" This reverts commit 23b62c0. * Missing packs hf (#22632) * removed condition where failed preview image fails the entire list. Fixed the case where deleted preview image is failing a single ack * fix function renaming * Fix pack collection conditions * Revert "Fix pack collection conditions" This reverts commit 23b62c0. * Fix valid preview image condition * Deprecate O365 S&C; Add O365 S&C V2 with Session Changes (#22188) * Missing packs hf (#22633) * removed condition where failed preview image fails the entire list. Fixed the case where deleted preview image is failing a single ack * fix function renaming * Fix pack collection conditions * Revert "Fix pack collection conditions" This reverts commit 23b62c0. * Fix valid preview image condition * Added debug * Removed redundant if statement * rmed corexXDR from the list Co-authored-by: Yaakov Praisler <59408745+yaakovpraisler@users.noreply.github.com> Co-authored-by: yaakovpraisler <ypreisler@paloaltonetworks.com> Co-authored-by: content-bot <55035720+content-bot@users.noreply.github.com> Co-authored-by: johnnywilkes <32227961+johnnywilkes@users.noreply.github.com> Co-authored-by: omerKarkKatz <95565843+omerKarkKatz@users.noreply.github.com> Co-authored-by: EyalPintzov <91007713+eyalpalo@users.noreply.github.com> Co-authored-by: Yuval Hayun <70104171+YuvHayun@users.noreply.github.com> Co-authored-by: MLainer1 <93524335+MLainer1@users.noreply.github.com> Co-authored-by: Ben Melamed <bmelamed@paloaltonetworks.com> Co-authored-by: evisochek <evisochek@paloaltonetworks.com> Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com> Co-authored-by: ostolero <86190583+ostolero@users.noreply.github.com> Co-authored-by: yasta5 <112320333+yasta5@users.noreply.github.com> Co-authored-by: Darya Koval <dkoval@paloaltonetworks.com> Co-authored-by: nkanon <109467661+nkanon@users.noreply.github.com> Co-authored-by: Dror Avrahami <davrahami@paloaltonetworks.com> Co-authored-by: xsoar-bot <67315154+xsoar-bot@users.noreply.github.com> Co-authored-by: Chang Liu <34745025+chang-ing@users.noreply.github.com> Co-authored-by: okarkkatz <okarkkatz@paloaltonetworks.com> Co-authored-by: Anar Azadaliyev <aazadaliyev@paloaltonetworks.com> Co-authored-by: merit-maita <49760643+merit-maita@users.noreply.github.com> Co-authored-by: Shahaf Ben Yakir <44666568+ShahafBenYakir@users.noreply.github.com> Co-authored-by: Andrew Shamah <42912128+amshamah419@users.noreply.github.com>
efelmandar
pushed a commit
that referenced
this pull request
Jan 4, 2023
* update core packs on MP and MPv2 * rm type * rm redundant comma * Update Tests/Marketplace/core_packs_list.json Co-authored-by: Yaakov Praisler <59408745+yaakovpraisler@users.noreply.github.com> * Update Tests/Marketplace/core_packs_list.json Co-authored-by: Yaakov Praisler <59408745+yaakovpraisler@users.noreply.github.com> * Update Tests/Marketplace/core_packs_list.json * Jwilkes tenable (#22595) * Jwilkes tenable (#22548) * EXPANDR-89 - init * unit test first draft * more unit test work * finished unit tests * format and removed comments * updated integration README * rel notes * Apply suggestions from code review Co-authored-by: omerKarkKatz <95565843+omerKarkKatz@users.noreply.github.com> * bug fix, docstring, types * fixed flake errors * Update Packs/Tenable_io/Integrations/Tenable_io/Tenable_io.py Co-authored-by: omerKarkKatz <95565843+omerKarkKatz@users.noreply.github.com> * Update Packs/Tenable_io/Integrations/Tenable_io/Tenable_io.yml * update docker image Co-authored-by: omerKarkKatz <95565843+omerKarkKatz@users.noreply.github.com> * Update Packs/Tenable_io/ReleaseNotes/2_1_0.md Co-authored-by: johnnywilkes <32227961+johnnywilkes@users.noreply.github.com> Co-authored-by: omerKarkKatz <95565843+omerKarkKatz@users.noreply.github.com> * Validation fix (#22611) * poetry * revert * validations failure fixed * release notes * add_comment_to_approved_categories (#22609) * TIM - fix IP regex in CSP (#22590) * fix IP regex * DOCKER IMAGE * added . * update new regex * XCLOUD Cryptomining (#22402) * test * test * XCLOUD Cryptomining files * update RN * fixes * added incident type+layout * added scripts * docs * fix secrets * fixes * fixes * fixes * incident fields fixes * fixes skipifunavailable * fixes skipifunavailable * fix scripts naming in the layout * added packs readme info * fix png * fix png * fix incident fields * update CommonTypes RN * fixes * fixes * fixes * fixes * Update playbook-Cloud_Response_-_AWS_README.md Done. * Update playbook-Cloud_Response_-_AWS.yml Done. * Update README.md Done. * Update 1_0_1.md Done. * Update playbook-Cloud_Response_-_Azure.yml Done * Update playbook-Cloud_Response_-_AWS.yml Done. * Update playbook-Cloud_Response_-_Azure_README.md Done. * Update README.md Done. * Update playbook-Cloud_Response_-_Generic.yml Done. * Update 2_3_14.md Done. * Update Cortex_XDR_Alerts_Handling.yml Done. * Update Cortex_XDR_Alerts_Handling_README.md Done * Update Cortex_XDR_Alerts_Handling.yml Done. * Update playbook-Account_Enrichment_-_Generic_v2.2.yml Done. * Update Cortex_XDR_incident_handling_v3.yml Done. * Update playbook-Cloud_Cryptomining.yml Done. * Update playbook-Cloud_Cryptomining_README.md Done. * Update playbook-Cloud_Enrichment.yml Done. * Update playbook-Cloud_Enrichment_README.md Done. * Update playbook-Cryptomining_-_Set_Verdict.yml Done. * Update playbook-Cryptomining_-_Set_Verdict_README.md Done. * Update 4_9_4.md Done. * Update playbook-Cloud_Response_-_GCP.yml Done. * Update playbook-Cloud_Response_-_GCP_README.md Done. * Update README.md Done. * fixes * fix * fix readme * fix readme * typos * typos * fix AWS playbook * fix AWS playbook * fix Azure playbook * fix GCP playbook * fix naming and skipifunavailable * added new playbook input "sourceIP" to all sub-playbooks * fix setIfEmpty * fix setIfEmpty * added associated types * changed default playbook * typos * added "systemAssociatedTypes" * added playbook outputs * added playbook outputs * fix img name in readme * fix docker version * update RN * fix * update RN Co-authored-by: evisochek <evisochek@paloaltonetworks.com> Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com> * remove o365 check for pyEWS_Test (#22329) * remove test * add rn * update docket image * replace rn * update docker * update rn * fix rn * fix rn * Remove duplicate mapping from the Modeling rule. (#22583) * Remove duplicate mapping from the Modeling rule. * created releaso notes files * Changed text in the release note. Co-authored-by: Darya Koval <dkoval@paloaltonetworks.com> * ParsingRules Nadav Demo 2 (#22592) * Added Jira ParsingRules * Added Mimecast ParsingRules * Added OktaOAG ParsingRules * Update OktaOAGParsingRules.xif * Update JiraParsingRules.xif * URL formatter returning an output when encountering escape chars at end of url (#22588) * URL Formatter better handling escape chars * URL Formatter better handling escape chars * RN * Update FormatURL.py * unneeded white space. * Update FormatURL.py * Update FormatURL_test.py * Removed lower() from formatter to return a case sensitive URL. * Update 1_10_16.md * Validation fixes. * RN * Update FormatURL_test.py * Updated test playbook with case sensitive URLs * [Marketplace Contribution] Akamai WAF - Content Pack Update (#22614) * [Marketplace Contribution] Akamai WAF - Content Pack Update (#22576) * "contribution update to pack "Akamai WAF"" * Update 2_0_2.md * Update Packs/Akamai_WAF/Integrations/Akamai_WAF/Akamai_WAF.yml Co-authored-by: omerKarkKatz <95565843+omerKarkKatz@users.noreply.github.com> * Update Packs/Akamai_WAF/ReleaseNotes/2_0_2.md Co-authored-by: omerKarkKatz <95565843+omerKarkKatz@users.noreply.github.com> Co-authored-by: Chang Liu <34745025+chang-ing@users.noreply.github.com> Co-authored-by: omerKarkKatz <95565843+omerKarkKatz@users.noreply.github.com> * reverted the description change * Apply suggestions from code review updated release notes * Update Packs/Akamai_WAF/Integrations/Akamai_WAF/Akamai_WAF.yml updated yml docker image Co-authored-by: xsoar-bot <67315154+xsoar-bot@users.noreply.github.com> Co-authored-by: Chang Liu <34745025+chang-ing@users.noreply.github.com> Co-authored-by: omerKarkKatz <95565843+omerKarkKatz@users.noreply.github.com> Co-authored-by: okarkkatz <okarkkatz@paloaltonetworks.com> * Remove correlation rules (#22620) * remove correlation rules * update release notes * fix Alibaba release notes (#22624) * Removed XSIAM Dashboards (#22625) * Removed CyberArkDashboard * Removed Dropbox DropboxDashboard * Removed XSIAMDashboards * Updated ReleaseNotes * Teams docs update (#22426) * added some documentation * added some documentation * added rn * added tutorial video * updated docker image * updated docker image * removed condition where failed preview image fails the entire list. (#22627) * removed condition where failed preview image fails the entire list. Fixed the case where deleted preview image is failing a single ack * fix function renaming * Fix pack collection conditions * Revert "Fix pack collection conditions" This reverts commit 23b62c0. * Missing packs hf (#22632) * removed condition where failed preview image fails the entire list. Fixed the case where deleted preview image is failing a single ack * fix function renaming * Fix pack collection conditions * Revert "Fix pack collection conditions" This reverts commit 23b62c0. * Fix valid preview image condition * Deprecate O365 S&C; Add O365 S&C V2 with Session Changes (#22188) * Missing packs hf (#22633) * removed condition where failed preview image fails the entire list. Fixed the case where deleted preview image is failing a single ack * fix function renaming * Fix pack collection conditions * Revert "Fix pack collection conditions" This reverts commit 23b62c0. * Fix valid preview image condition * Added debug * Removed redundant if statement * rmed corexXDR from the list Co-authored-by: Yaakov Praisler <59408745+yaakovpraisler@users.noreply.github.com> Co-authored-by: yaakovpraisler <ypreisler@paloaltonetworks.com> Co-authored-by: content-bot <55035720+content-bot@users.noreply.github.com> Co-authored-by: johnnywilkes <32227961+johnnywilkes@users.noreply.github.com> Co-authored-by: omerKarkKatz <95565843+omerKarkKatz@users.noreply.github.com> Co-authored-by: EyalPintzov <91007713+eyalpalo@users.noreply.github.com> Co-authored-by: Yuval Hayun <70104171+YuvHayun@users.noreply.github.com> Co-authored-by: MLainer1 <93524335+MLainer1@users.noreply.github.com> Co-authored-by: Ben Melamed <bmelamed@paloaltonetworks.com> Co-authored-by: evisochek <evisochek@paloaltonetworks.com> Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com> Co-authored-by: ostolero <86190583+ostolero@users.noreply.github.com> Co-authored-by: yasta5 <112320333+yasta5@users.noreply.github.com> Co-authored-by: Darya Koval <dkoval@paloaltonetworks.com> Co-authored-by: nkanon <109467661+nkanon@users.noreply.github.com> Co-authored-by: Dror Avrahami <davrahami@paloaltonetworks.com> Co-authored-by: xsoar-bot <67315154+xsoar-bot@users.noreply.github.com> Co-authored-by: Chang Liu <34745025+chang-ing@users.noreply.github.com> Co-authored-by: okarkkatz <okarkkatz@paloaltonetworks.com> Co-authored-by: Anar Azadaliyev <aazadaliyev@paloaltonetworks.com> Co-authored-by: merit-maita <49760643+merit-maita@users.noreply.github.com> Co-authored-by: Shahaf Ben Yakir <44666568+ShahafBenYakir@users.noreply.github.com> Co-authored-by: Andrew Shamah <42912128+amshamah419@users.noreply.github.com>
xsoar-bot
added a commit
to xsoar-contrib/content
that referenced
this pull request
Jan 11, 2023
* update core packs on MP and MPv2 * rm type * rm redundant comma * Update Tests/Marketplace/core_packs_list.json Co-authored-by: Yaakov Praisler <59408745+yaakovpraisler@users.noreply.github.com> * Update Tests/Marketplace/core_packs_list.json Co-authored-by: Yaakov Praisler <59408745+yaakovpraisler@users.noreply.github.com> * Update Tests/Marketplace/core_packs_list.json * Jwilkes tenable (demisto#22595) * Jwilkes tenable (demisto#22548) * EXPANDR-89 - init * unit test first draft * more unit test work * finished unit tests * format and removed comments * updated integration README * rel notes * Apply suggestions from code review Co-authored-by: omerKarkKatz <95565843+omerKarkKatz@users.noreply.github.com> * bug fix, docstring, types * fixed flake errors * Update Packs/Tenable_io/Integrations/Tenable_io/Tenable_io.py Co-authored-by: omerKarkKatz <95565843+omerKarkKatz@users.noreply.github.com> * Update Packs/Tenable_io/Integrations/Tenable_io/Tenable_io.yml * update docker image Co-authored-by: omerKarkKatz <95565843+omerKarkKatz@users.noreply.github.com> * Update Packs/Tenable_io/ReleaseNotes/2_1_0.md Co-authored-by: johnnywilkes <32227961+johnnywilkes@users.noreply.github.com> Co-authored-by: omerKarkKatz <95565843+omerKarkKatz@users.noreply.github.com> * Validation fix (demisto#22611) * poetry * revert * validations failure fixed * release notes * add_comment_to_approved_categories (demisto#22609) * TIM - fix IP regex in CSP (demisto#22590) * fix IP regex * DOCKER IMAGE * added . * update new regex * XCLOUD Cryptomining (demisto#22402) * test * test * XCLOUD Cryptomining files * update RN * fixes * added incident type+layout * added scripts * docs * fix secrets * fixes * fixes * fixes * incident fields fixes * fixes skipifunavailable * fixes skipifunavailable * fix scripts naming in the layout * added packs readme info * fix png * fix png * fix incident fields * update CommonTypes RN * fixes * fixes * fixes * fixes * Update playbook-Cloud_Response_-_AWS_README.md Done. * Update playbook-Cloud_Response_-_AWS.yml Done. * Update README.md Done. * Update 1_0_1.md Done. * Update playbook-Cloud_Response_-_Azure.yml Done * Update playbook-Cloud_Response_-_AWS.yml Done. * Update playbook-Cloud_Response_-_Azure_README.md Done. * Update README.md Done. * Update playbook-Cloud_Response_-_Generic.yml Done. * Update 2_3_14.md Done. * Update Cortex_XDR_Alerts_Handling.yml Done. * Update Cortex_XDR_Alerts_Handling_README.md Done * Update Cortex_XDR_Alerts_Handling.yml Done. * Update playbook-Account_Enrichment_-_Generic_v2.2.yml Done. * Update Cortex_XDR_incident_handling_v3.yml Done. * Update playbook-Cloud_Cryptomining.yml Done. * Update playbook-Cloud_Cryptomining_README.md Done. * Update playbook-Cloud_Enrichment.yml Done. * Update playbook-Cloud_Enrichment_README.md Done. * Update playbook-Cryptomining_-_Set_Verdict.yml Done. * Update playbook-Cryptomining_-_Set_Verdict_README.md Done. * Update 4_9_4.md Done. * Update playbook-Cloud_Response_-_GCP.yml Done. * Update playbook-Cloud_Response_-_GCP_README.md Done. * Update README.md Done. * fixes * fix * fix readme * fix readme * typos * typos * fix AWS playbook * fix AWS playbook * fix Azure playbook * fix GCP playbook * fix naming and skipifunavailable * added new playbook input "sourceIP" to all sub-playbooks * fix setIfEmpty * fix setIfEmpty * added associated types * changed default playbook * typos * added "systemAssociatedTypes" * added playbook outputs * added playbook outputs * fix img name in readme * fix docker version * update RN * fix * update RN Co-authored-by: evisochek <evisochek@paloaltonetworks.com> Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com> * remove o365 check for pyEWS_Test (demisto#22329) * remove test * add rn * update docket image * replace rn * update docker * update rn * fix rn * fix rn * Remove duplicate mapping from the Modeling rule. (demisto#22583) * Remove duplicate mapping from the Modeling rule. * created releaso notes files * Changed text in the release note. Co-authored-by: Darya Koval <dkoval@paloaltonetworks.com> * ParsingRules Nadav Demo 2 (demisto#22592) * Added Jira ParsingRules * Added Mimecast ParsingRules * Added OktaOAG ParsingRules * Update OktaOAGParsingRules.xif * Update JiraParsingRules.xif * URL formatter returning an output when encountering escape chars at end of url (demisto#22588) * URL Formatter better handling escape chars * URL Formatter better handling escape chars * RN * Update FormatURL.py * unneeded white space. * Update FormatURL.py * Update FormatURL_test.py * Removed lower() from formatter to return a case sensitive URL. * Update 1_10_16.md * Validation fixes. * RN * Update FormatURL_test.py * Updated test playbook with case sensitive URLs * [Marketplace Contribution] Akamai WAF - Content Pack Update (demisto#22614) * [Marketplace Contribution] Akamai WAF - Content Pack Update (demisto#22576) * "contribution update to pack "Akamai WAF"" * Update 2_0_2.md * Update Packs/Akamai_WAF/Integrations/Akamai_WAF/Akamai_WAF.yml Co-authored-by: omerKarkKatz <95565843+omerKarkKatz@users.noreply.github.com> * Update Packs/Akamai_WAF/ReleaseNotes/2_0_2.md Co-authored-by: omerKarkKatz <95565843+omerKarkKatz@users.noreply.github.com> Co-authored-by: Chang Liu <34745025+chang-ing@users.noreply.github.com> Co-authored-by: omerKarkKatz <95565843+omerKarkKatz@users.noreply.github.com> * reverted the description change * Apply suggestions from code review updated release notes * Update Packs/Akamai_WAF/Integrations/Akamai_WAF/Akamai_WAF.yml updated yml docker image Co-authored-by: xsoar-bot <67315154+xsoar-bot@users.noreply.github.com> Co-authored-by: Chang Liu <34745025+chang-ing@users.noreply.github.com> Co-authored-by: omerKarkKatz <95565843+omerKarkKatz@users.noreply.github.com> Co-authored-by: okarkkatz <okarkkatz@paloaltonetworks.com> * Remove correlation rules (demisto#22620) * remove correlation rules * update release notes * fix Alibaba release notes (demisto#22624) * Removed XSIAM Dashboards (demisto#22625) * Removed CyberArkDashboard * Removed Dropbox DropboxDashboard * Removed XSIAMDashboards * Updated ReleaseNotes * Teams docs update (demisto#22426) * added some documentation * added some documentation * added rn * added tutorial video * updated docker image * updated docker image * removed condition where failed preview image fails the entire list. (demisto#22627) * removed condition where failed preview image fails the entire list. Fixed the case where deleted preview image is failing a single ack * fix function renaming * Fix pack collection conditions * Revert "Fix pack collection conditions" This reverts commit 23b62c0. * Missing packs hf (demisto#22632) * removed condition where failed preview image fails the entire list. Fixed the case where deleted preview image is failing a single ack * fix function renaming * Fix pack collection conditions * Revert "Fix pack collection conditions" This reverts commit 23b62c0. * Fix valid preview image condition * Deprecate O365 S&C; Add O365 S&C V2 with Session Changes (demisto#22188) * Missing packs hf (demisto#22633) * removed condition where failed preview image fails the entire list. Fixed the case where deleted preview image is failing a single ack * fix function renaming * Fix pack collection conditions * Revert "Fix pack collection conditions" This reverts commit 23b62c0. * Fix valid preview image condition * Added debug * Removed redundant if statement * rmed corexXDR from the list Co-authored-by: Yaakov Praisler <59408745+yaakovpraisler@users.noreply.github.com> Co-authored-by: yaakovpraisler <ypreisler@paloaltonetworks.com> Co-authored-by: content-bot <55035720+content-bot@users.noreply.github.com> Co-authored-by: johnnywilkes <32227961+johnnywilkes@users.noreply.github.com> Co-authored-by: omerKarkKatz <95565843+omerKarkKatz@users.noreply.github.com> Co-authored-by: EyalPintzov <91007713+eyalpalo@users.noreply.github.com> Co-authored-by: Yuval Hayun <70104171+YuvHayun@users.noreply.github.com> Co-authored-by: MLainer1 <93524335+MLainer1@users.noreply.github.com> Co-authored-by: Ben Melamed <bmelamed@paloaltonetworks.com> Co-authored-by: evisochek <evisochek@paloaltonetworks.com> Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com> Co-authored-by: ostolero <86190583+ostolero@users.noreply.github.com> Co-authored-by: yasta5 <112320333+yasta5@users.noreply.github.com> Co-authored-by: Darya Koval <dkoval@paloaltonetworks.com> Co-authored-by: nkanon <109467661+nkanon@users.noreply.github.com> Co-authored-by: Dror Avrahami <davrahami@paloaltonetworks.com> Co-authored-by: xsoar-bot <67315154+xsoar-bot@users.noreply.github.com> Co-authored-by: Chang Liu <34745025+chang-ing@users.noreply.github.com> Co-authored-by: okarkkatz <okarkkatz@paloaltonetworks.com> Co-authored-by: Anar Azadaliyev <aazadaliyev@paloaltonetworks.com> Co-authored-by: merit-maita <49760643+merit-maita@users.noreply.github.com> Co-authored-by: Shahaf Ben Yakir <44666568+ShahafBenYakir@users.noreply.github.com> Co-authored-by: Andrew Shamah <42912128+amshamah419@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributing to Cortex XSOAR Content
Make sure to register your contribution by filling the contribution registration form
The Pull Request will be reviewed only after the contribution registration form is filled.
Status
Related Issues
https://jira-hq.paloaltonetworks.local/browse/CIAC-4058
https://jira-hq.paloaltonetworks.local/browse/EXPANDR-89
Description
Added the !tenable-io-get-asset-details command to be able to look up asset information and custom attributes.
Screenshots
Minimum version of Cortex XSOAR
Does it break backward compatibility?
Must have