8000 Mail Listener fix by yucohen · Pull Request #22753 · demisto/content · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Mail Listener fix #22753

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 18 commits into from
Dec 18, 2022
Merged

Mail Listener fix #22753

merged 18 commits into from
Dec 18, 2022

Conversation

yucohen
Copy link
Contributor
@yucohen yucohen commented Dec 7, 2022 •
edited
Loading

Status

  • In Progress
  • Ready
  • In Hold - (Reason for hold)

Related Issues

fixes: https://jira-hq.paloaltonetworks.local/browse/XSUP-19156

Description

In some cases, the date header of the mail is empty and fails once it is none.
Assigned the occurred time for the incident to be "now" instead of skipping it.

Must have

  • Tests
  • Documentation

@yucohen yucohen added the bug label Dec 11, 2022
@yucohen yucohen requested a review from DeanArbel December 11, 2022 13:20
@yucohen yucohen marked this pull request as ready for review December 11, 2022 13:20
DeanArbel
DeanArbel reviewed Dec 13, 2022
View reviewed changes
DeanArbel
DeanArbel reviewed Dec 13, 2022
View reviewed changes
@ShirleyDenkberg ShirleyDenkberg self-assigned this Dec 14, 2022
@ShirleyDenkberg
Copy link
Contributor

@DeanArbel Doc review completed.

@yucohen yucohen requested a review from a team as a code owner December 15, 2022 07:43
@yucohen yucohen removed the request for review from a team December 15, 2022 07:47
@bakatzir bakatzir mentioned this pull request Dec 15, 2022
Merged
1 task
@xsoar-bot
Copy link
Contributor

Link to the unit tests coverage report:
https://output.circle-artifacts.com/output/job/7c4a8179-ea52-48ec-ad9d-318d4893cebc/artifacts/0/artifacts/coverage_report/html/index.html

@yucohen yucohen merged commit 5977e98 into master Dec 18, 2022
@yucohen yucohen deleted the mail_listener_fix branch December 18, 2022 09:27
efelmandar pushed a commit that referenced this pull request Jan 4, 2023
@yucohen @ShirleyDenkberg @efelmandar
Mail Listener fix (#22753)
5a63d00 
* fixed Nonetype object has no attribute isoformat issue

* added test

* added test and set mails with no time to be with "now" time

* added to readme

* rn

* log

* lint

* docker image

Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>
xsoar-bot pushed a commit to xsoar-contrib/content that referenced this pull request Jan 11, 2023
@yucohen @ShirleyDenkberg @xsoar-bot
Mail Listener fix (demisto#22753)
40195b5 
* fixed Nonetype object has no attribute isoformat issue

* added test

* added test and set mails with no time to be with "now" time

* added to readme

* rn

* log

* lint

* docker image

Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DeanArbel DeanArbel DeanArbel approved these changes

Assignees

@ShirleyDenkberg ShirleyDenkberg

Labels
bug docs-approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@yucohen @ShirleyDenkberg @xsoar-bot @DeanArbel
0