8000 [ASM] expandr-1587 by johnnywilkes · Pull Request #23018 · demisto/content · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[ASM] expandr-1587 #23018

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

johnnywilkes
Copy link
Contributor
@johnnywilkes johnnywilkes commented Dec 13, 2022

Contributing to Cortex XSOAR Content

Make sure to register your contribution by filling the contribution registration form

The Pull Request will be reviewed only after the contribution registration form is filled.

Status

  • In Progress
  • Ready
  • In Hold - (Reason for hold)

Related Issues

https://jira-hq.paloaltonetworks.local/browse/EXPANDR-1587 (parent)
https://jira-hq.paloaltonetworks.local/browse/EXPANDR-1942
https://jira-hq.paloaltonetworks.local/browse/EXPANDR-1994

Description

Previously the playbook was only focuses on two ASM use cases: RDP Server and Insecure OpenSSH. This PR included changes to open this up to four more use cases: Telnet, Unencrypted FTP, OpenSSH and SSH Server. We wanted to spell this out in the Pack README for visibility.

Screenshots

Before
image
image

After
image
image

Other before/after screenshots in https://jira-hq.paloaltonetworks.local/browse/EXPANDR-1942
and
https://jira-hq.paloaltonetworks.local/browse/EXPANDR-1994

Minimum version of Cortex XSOAR

  • 6.0.0
  • 6.1.0
  • 6.2.0
  • 6.5.0

Does it break backward compatibility?

  • Yes
    • Further details:
  • No

Must have

  • Tests
  • Documentation

@content-bot content-bot added the Contribution Thank you! Contributions are always welcome! label Dec 13, 2022
@content-bot content-bot changed the base branch from master to contrib/BigEasyJ_ASM-EXPANDR-1587 December 13, 2022 14:36
@content-bot
Copy link
Collaborator

Thank you for your contribution. Your generosity and caring are unrivaled! Make sure to register your contribution by filling the Contribution Registration form, so our content wizard @omerKarkKatz will know he can start review the proposed changes.

@content-bot content-bot added Community Contribution Form Filled Whether contribution form filled or not. labels Dec 13, 2022
@efelmandar
Copy link
Contributor

@johnnywilkes Thank you for your patience and hard work, the changes look great! @omerKarkKatz please merge

@omerKarkKatz omerKarkKatz merged commit fceebad into demisto:contrib/BigEasyJ_ASM-EXPANDR-1587 Jan 3, 2023 8000
@content-bot content-bot mentioned this pull request Jan 3, 2023
11 tasks
omerKarkKatz pushed a commit that referenced this pull request Jan 3, 2023
* EXPANDR-1587

* release notes

* update rel notes

* adding EXPANDR-1942 bugfix

* rel notes

* EXPANDR-1994

Co-authored-by: johnnywilkes <32227961+johnnywilkes@users.noreply.github.com>
efelmandar pushed a commit that referenced this pull request Jan 4, 2023
* EXPANDR-1587

* release notes

* update rel notes

* adding EXPANDR-1942 bugfix

* rel notes

* EXPANDR-1994

Co-authored-by: johnnywilkes <32227961+johnnywilkes@users.noreply.github.com>
@johnnywilkes johnnywilkes deleted the ASM-EXPANDR-1587 branch January 4, 2023 18:49
xsoar-bot pushed a commit to xsoar-contrib/content that referenced this pull request Jan 11, 2023
* EXPANDR-1587

* release notes

* update rel notes

* adding EXPANDR-1942 bugfix

* rel notes

* EXPANDR-1994

Co-authored-by: johnnywilkes <32227961+johnnywilkes@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Community Contribution Form Filled Whether contribution form filled or not. Contribution Thank you! Contributions are always welcome!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants
0