10000 Hide fetch param sample generator by anara123 · Pull Request #23432 · demisto/content · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Hide fetch param sample generator #23432

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 3, 2023
Merged

Hide fetch param sample generator #23432

merged 2 commits into from
Jan 3, 2023

Conversation

anara123
Copy link
Contributor
@anara123 anara123 commented Jan 1, 2023

Status

  • In Progress
  • Ready
  • In Hold - (Reason for hold)

Related Issues

fixes: link to the issue

Description

Hide fetch param sample generator

Screenshots

Paste here any images that will help the reviewer

Minimum version of Cortex XSOAR

  • 6.0.0
  • 6.1.0
  • 6.2.0
  • 6.5.0

Does it break backward compatibility?

  • Yes
    • Further details:
  • No

Must have

  • Tests
  • Documentation

@anara123 anara123 requested a review from glicht January 1, 2023 10:51
@anara123
Copy link
Contributor Author
anara123 commented Jan 2, 2023

The build fails on

[ERROR]: Packs/sampleSiem/Integrations/SampleIncidentGenerator/SampleIncidentGenerator.yml: [IN129] - You've removed integration parameters, the removed parameters are '{'runEveryXMinutes'}'

But that is intentional.

@anara123 anara123 merged commit 58281e3 into master Jan 3, 2023
@anara123 anara123 deleted the hide-fetch-param-sample-generator branch January 3, 2023 10:23
efelmandar pushed a commit that referenced this pull request Jan 4, 2023
@anara123 @efelmandar
remove fetch param (#23432)
1481995
xsoar-bot pushed a commit to xsoar-contrib/content that referenced this pull request Jan 11, 2023
@anara123 @xsoar-bot
remove fetch param (demisto#23432)
3669f87
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glicht glicht glicht approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@anara123 @glicht
0