8000 [Marketplace Contribution] ThreatGrid by content-bot · Pull Request #23525 · demisto/content · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[Marketplace Contribution] ThreatGrid #23525

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 3, 2023
Merged

[Marketplace Contribution] ThreatGrid #23525

merged 1 commit into from
Jan 3, 2023

Conversation

content-bot
Copy link
Collaborator

Original External PR

external pull request

Status

  • In Progress
  • Ready
  • In Hold - (Reason for hold)

Contributor

@amkoppad

Notes

Added the two commands to the integration.

  1. !threat-grid-advanced-search
  2. !threat-grid-submit-urls
    Adding these two commands to the integration make the implementation with XSOAR more efficient.
    Without the !threat-grid-submit-urls command urls first have to be converted to files and then uploaded to ThreatGrid as samples.
    !threat-grid-advanced-search command enables XSOAR to run the ThreatGrid query search.

Video Link

Short demo video of the Pack usage. Speeds up the review. Optional but recommended. Use a video sharing service such as Google Drive or YouTube.

@xsoar-bot @amkoppad @JasBeilin
[Marketplace Contribution] ThreatGrid (#21611)
32667ff
8000 
* "contribution update to pack "Cisco Secure Malware Analytics""

* Update ThreatGridDev.yml

* added commands in original integration

* Update ThreatGridDev.yml

* fixed RN

* Update Packs/ThreatGrid/Integrations/ThreatGrid/ThreatGrid.py

Co-authored-by: Jasmine Beilin <71636766+JasBeilin@users.noreply.github.com>

* Update Packs/ThreatGrid/Integrations/ThreatGrid/ThreatGrid.py

Co-authored-by: Jasmine Beilin <71636766+JasBeilin@users.noreply.github.com>

* Update Packs/ThreatGrid/Integrations/ThreatGrid/ThreatGrid.py

Co-authored-by: Jasmine Beilin <71636766+JasBeilin@users.noreply.github.com>

* Made the suggested changes to the advanced_search function and added the desciption for outputs in .yml file

* Added a test function and addressed the previous build errors

* Modified the test function

* Modified the test function

* Modified the test function v3

* Fixed the type errors

* Fixed the submit_urls test function

* Adding the test function for advanced search function

* Fixed mocking the requests object

* Fixed test_data path

* Test function fix 2

* Test function fix 3

* Test function fix 4

* Test function fix 5

* Modified the yml file to exclude image tag

* Modified python function for test function

* Modified the mock_response object

* Fixed the request typeerror

* Modified the mock_data

* TypeError fix 2

* Changed the mocker object

* This should fix all the test functions

* Fixed the image version issue

* Fixed Readme

* Fixed the lint errors

* Update README.md

Fixed the README issues.

Co-authored-by: amkoppad <82898085+amkoppad@users.noreply.github.com>
Co-authored-by: Jas Beilin <jgranot@paloaltonetworks.com>
Co-authored-by: Jasmine Beilin <71636766+JasBeilin@users.noreply.github.com>
Co-authored-by: amkoppad <amit.koppad@paloaltonetworks.com>
@content-bot content-bot added Contribution Thank you! Contributions are always welcome! docs-approved pending-contributor The PR is pending the response of its creator labels Jan 3, 2023
@content-bot content-bot requested a review from JasBeilin January 3, 2023 16:18
@xsoar-bot
Copy link
Contributor

Link to the unit tests coverage report:
https://output.circle-artifacts.com/output/job/38598039-25aa-432d-b503-eaeeff5f6149/artifacts/0/artifacts/coverage_report/html/index.html

@JasBeilin
Copy link
Contributor

Commenting here for documentation-
We are merging this PR in order to have a fix for customer, the design of this addition is taken into consideration in a V2 version that should be available soon.

@JasBeilin JasBeilin merged commit f5c4f1d into master Jan 3, 2023
@JasBeilin JasBeilin deleted the contrib/xsoar-contrib_amkoppad-contrib-ThreatGrid branch January 3, 2023 17:42
efelmandar pushed a commit that referenced this pull request Jan 4, 2023
@content-bot @xsoar-bot
@amkoppad @JasBeilin @efelmandar
[Marketplace Contribution] ThreatGrid (#21611) (#23525)
1488f0c 
* "contribution update to pack "Cisco Secure Malware Analytics""

* Update ThreatGridDev.yml

* added commands in original integration

* Update ThreatGridDev.yml

* fixed RN

* Update Packs/ThreatGrid/Integrations/ThreatGrid/ThreatGrid.py

Co-authored-by: Jasmine Beilin <71636766+JasBeilin@users.noreply.github.com>

* Update Packs/ThreatGrid/Integrations/ThreatGrid/ThreatGrid.py

Co-authored-by: Jasmine Beilin <71636766+JasBeilin@users.noreply.github.com>

* Update Packs/ThreatGrid/Integrations/ThreatGrid/ThreatGrid.py

Co-authored-by: Jasmine Beilin <71636766+JasBeilin@users.noreply.github.com>

* Made the suggested changes to the advanced_search function and added the desciption for outputs in .yml file

* Added a test function and addressed the previous build errors

* Modified the test function

* Modified the test function

* Modified the test function v3

* Fixed the type errors

* Fixed the submit_urls test function

* Adding the test function for advanced search function

* Fixed mocking the requests object

* Fixed test_data path

* Test function fix 2

* Test function fix 3

* Test function fix 4

* Test function fix 5

* Modified the yml file to exclude image tag

* Modified python function for test function

* Modified the mock_response object

* Fixed the request typeerror

* Modified the mock_data

* TypeError fix 2

* Changed the mocker object

* This should fix all the test functions

* Fixed the image version issue

* Fixed Readme

* Fixed the lint errors

* Update README.md

Fixed the README issues.

Co-authored-by: amkoppad <82898085+amkoppad@users.noreply.github.com>
Co-authored-by: Jas Beilin <jgranot@paloaltonetworks.com>
Co-authored-by: Jasmine Beilin <71636766+JasBeilin@users.noreply.github.com>
Co-authored-by: amkoppad <amit.koppad@paloaltonetworks.com>

Co-authored-by: xsoar-bot <67315154+xsoar-bot@users.noreply.github.com>
Co-authored-by: amkoppad <82898085+amkoppad@users.noreply.github.com>
Co-authored-by: Jas Beilin <jgranot@paloaltonetworks.com>
Co-authored-by: Jasmine Beilin <71636766+JasBeilin@users.noreply.github.com>
Co-authored-by: amkoppad <amit.koppad@paloaltonetworks.com>
ckaadic pushed a commit to ckaadic/content that referenced this pull request Jan 10, 2023
@content-bot @xsoar-bot
@amkoppad @JasBeilin @ckaadic
[Marketplace Contribution] ThreatGrid (demisto#21611) (demisto#23525)
8f7768a 
* "contribution update to pack "Cisco Secure Malware Analytics""

* Update ThreatGridDev.yml

* added commands in original integration

* Update ThreatGridDev.yml

* fixed RN

* Update Packs/ThreatGrid/Integrations/ThreatGrid/ThreatGrid.py

Co-authored-by: Jasmine Beilin <71636766+JasBeilin@users.noreply.github.com>

* Update Packs/ThreatGrid/Integrations/ThreatGrid/ThreatGrid.py

Co-authored-by: Jasmine Beilin <71636766+JasBeilin@users.noreply.github.com>

* Update Packs/ThreatGrid/Integrations/ThreatGrid/ThreatGrid.py

Co-authored-by: Jasmine Beilin <71636766+JasBeilin@users.noreply.github.com>

* Made the suggested changes to the advanced_search function and added the desciption for outputs in .yml file

* Added a test function and addressed the previous build errors

* Modified the test function

* Modified the test function

* Modified the test function v3

* Fixed the type errors

* Fixed the submit_urls test function

* Adding the test function for advanced search function

* Fixed mocking the requests object

* Fixed test_data path

* Test function fix 2

* Test function fix 3

* Test function fix 4

* Test function fix 5

* Modified the yml file to exclude image tag

* Modified python function for test function

* Modified the mock_response object

* Fixed the request typeerror

* Modified the mock_data

* TypeError fix 2

* Changed the mocker object

* This should fix all the test functions

* Fixed the image version issue

* Fixed Readme

* Fixed the lint errors

* Update README.md

Fixed the README issues.

Co-authored-by: amkoppad <82898085+amkoppad@users.noreply.github.com>
Co-authored-by: Jas Beilin <jgranot@paloaltonetworks.com>
Co-authored-by: Jasmine Beilin <71636766+JasBeilin@users.noreply.github.com>
Co-authored-by: amkoppad <amit.koppad@paloaltonetworks.com>

Co-authored-by: xsoar-bot <67315154+xsoar-bot@users.noreply.github.com>
Co-authored-by: amkoppad <82898085+amkoppad@users.noreply.github.com>
Co-authored-by: Jas Beilin <jgranot@paloaltonetworks.
8000
com>
Co-authored-by: Jasmine Beilin <71636766+JasBeilin@users.noreply.github.com>
Co-authored-by: amkoppad <amit.koppad@paloaltonetworks.com>
xsoar-bot added a commit to xsoar-contrib/content that referenced this pull request Jan 11, 2023
@content-bot @xsoar-bot
@amkoppad @JasBeilin
[Marketplace Contribution] ThreatGrid (demisto#21611) (demisto#23525)
14015f8 
* "contribution update to pack "Cisco Secure Malware Analytics""

* Update ThreatGridDev.yml

* added commands in original integration

* Update ThreatGridDev.yml

* fixed RN

* Update Packs/ThreatGrid/Integrations/ThreatGrid/ThreatGrid.py

Co-authored-by: Jasmine Beilin <71636766+JasBeilin@users.noreply.github.com>

* Update Packs/ThreatGrid/Integrations/ThreatGrid/ThreatGrid.py

Co-authored-by: Jasmine Beilin <71636766+JasBeilin@users.noreply.github.com>

* Update Packs/ThreatGrid/Integrations/ThreatGrid/ThreatGrid.py

Co-authored-by: Jasmine Beilin <71636766+JasBeilin@users.noreply.github.com>

* Made the suggested changes to the advanced_search function and added the desciption for outputs in .yml file

* Added a test function and addressed the previous build errors

* Modified the test function

* Modified the test function

* Modified the test function v3

* Fixed the type errors

* Fixed the submit_urls test function

* Adding the test function for advanced search function

* Fixed mocking the requests object

* Fixed test_data path

* Test function fix 2

* Test function fix 3

* Test function fix 4

* Test function fix 5

* Modified the yml file to exclude image tag

* Modified python function for test function

* Modified the mock_response object

* Fixed the request typeerror

* Modified the mock_data

* TypeError fix 2

* Changed the mocker object

* This should fix all the test functions

* Fixed the image version issue

* Fixed Readme

* Fixed the lint errors

* Update README.md

Fixed the README issues.

Co-authored-by: amkoppad <82898085+amkoppad@users.noreply.github.com>
Co-authored-by: Jas Beilin <jgranot@paloaltonetworks.com>
Co-authored-by: Jasmine Beilin <71636766+JasBeilin@users.noreply.github.com>
Co-authored-by: amkoppad <amit.koppad@paloaltonetworks.com>

Co-authored-by: xsoar-bot <67315154+xsoar-bot@users.noreply.github.com>
Co-authored-by: amkoppad <82898085+amkoppad@users.noreply.github.com>
Co-authored-by: Jas Beilin <jgranot@paloaltonetworks.com>
Co-authored-by: Jasmine Beilin <71636766+JasBeilin@users.noreply.github.com>
Co-authored-by: amkoppad <amit.koppad@paloaltonetworks.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JasBeilin JasBeilin JasBeilin approved these changes

Assignees

@JasBeilin JasBeilin

Labels
Contribution Thank you! Contributions are always welcome! docs-approved pending-contributor The PR is pending the response of its creator
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@content-bot @xsoar-bot @JasBeilin
0