8000 Fixed a bug in download malware by Shellyber · Pull Request #7400 · demisto/content · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fixed a bug in download malware #7400

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Jun 7, 2020
Merged

Fixed a bug in download malware #7400

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
3c8cf83
Fixed a bug in download malware
Shellyber Jun 4, 2020
5142806
Merge branch 'master' into fidelis-elevate-download-bug
Shellyber Jun 6, 2020
f3b533a
added rn and fixed cr
Shellyber Jun 6, 2020
dbed547
old changelog fix
Shellyber Jun 6, 2020
02b89c6
Updated
kirbles19 Jun 7, 2020
c25a079
Merge branch 'master' into fidelis-elevate-download-bug
Shellyber Jun 7, 2020
e79fed5
Merge branch 'fidelis-elevate-download-bug' of github.com:demisto/con…
Shellyber Jun 7, 2020
785cf81
added old changelog
Shellyber Jun 7, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Packs/FidelisElevateNetwork/Integrations/FidelisElevateNetwork/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
## [Unreleased]

Fixed file download functionality in the **fidelis-download-malware-file** command.

## [20.5.0] - 2020-05-12
-
Expand Down
6 changes: 2 additions & 4 deletions Packs/FidelisElevateNetwork/Integrations/FidelisElevateNetwork/FidelisElevateNetwork.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1030,12 +1030,10 @@ def request_dpath(alert_id):
if res.get('decodingPaths'):
dpath = res.get('decodingPaths')[0]
link_path = dpath.get('linkPath')
encoded_path = urllib.quote(link_path)

else:
encoded_path = None
raise Exception('Could not find the file path.')

return encoded_path
return link_path
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in case the condition is false, link_path doesn't exist here.



def download_malware_file_request(alert_id):
Expand Down
4 changes: 4 additions & 0 deletions Packs/FidelisElevateNetwork/ReleaseNotes/1_0_1.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@

### Integrations
- __Fidelis Elevate Network__
Fixed file download functionality in the **fidelis-download-malware-file** command.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

copy this to the CHANGELOG as well

30 changes: 15 additions & 15 deletions Packs/FidelisElevateNetwork/pack_metadata.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,16 +1,16 @@
{
"name": "Fidelis Elevate Network",
"description": "Automate Detection and Response to Network Threats and data leakage in your organization with Fidelis Elevate Network Integration.",
"support": "xsoar",
"currentVersion": "1.0.0",
"author": "Cortex XSOAR",
"url": "https://www.paloaltonetworks.com/cortex",
"email": "",
"created": "2020-04-14T00:00:00Z",
"categories": [
"Network Security"
],
"tags": [],
"useCases": [],
"keywords": []
}
"name": "Fidelis Elevate Network",
"description": "Automate Detection and Response to Network Threats and data leakage in your organization with Fidelis Elevate Network Integration.",
"support": "xsoar",
"currentVersion": "1.0.1",
"author": "Cortex XSOAR",
"url": "https://www.paloaltonetworks.com/cortex",
"email": "",
"created": "2020-04-14T00:00:00Z",
"categories": [
"Network Security"
],
"tags": [],
"useCases": [],
"keywords": []
}
0