8000 Hod/mitre layout by hod-alpert · Pull Request #8955 · demisto/content · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Hod/mitre layout #8955

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Sep 29, 2020
Merged

Hod/mitre layout #8955

merged 9 commits into from
Sep 29, 2020

Conversation

hod-alpert
Copy link
Contributor
@hod-alpert hod-alpert commented Sep 15, 2020 •
edited
Loading

Status

  • In Progress
  • Ready
  • In Hold - (Reason for hold)

Related Issues

https://github.com/demisto/etc/issues/23383

Description

Edited the MITRE Att&ck layout

Screenshots

image

Minimum version of Demisto

  • 5.0.0
  • 5.5.0
  • 6.0.0

Does it break backward compatibility?

  • Yes
  • No

@hod-alpert hod-alpert force-pushed the hod/mitre_layout branch 4 times, most recently from bc6c7b6 to a3b51f7 Compare September 15, 2020 12:37
@hod-alpert hod-alpert added the release-notes-only 8000 Indicates that this pull request has ONLY release notes to review for documentation process label Sep 15, 2020
@hod-alpert hod-alpert requested a review from Itay4 September 15, 2020 14:21
@Itay4
Copy link
Contributor
Itay4 commented Sep 15, 2020

@hod-alpert any reason for this to still be in draft?

@Itay4 Itay4 removed the release-notes-only Indicates that this pull request has ONLY release notes to review for documentation process label Sep 15, 2020
Itay4
Itay4 suggested changes Sep 15, 2020
View reviewed changes
Copy link
Contributor
@Itay4 Itay4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lets go over this together

Packs/FeedMitreAttack/Integrations/FeedMitreAttack/FeedMitreAttack.py Outdated

from typing import List, Dict, Set
import json
import requests
from stix2 import TAXIICollectionSource, Filter
from taxii2client import Server, Collection, ApiRoot
from taxii2client.v20 import Server, Collection, ApiRoot
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

make sure you're synced with https://github.com/demisto/etc/issues/26353 with these change

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Synced, He implemented the same solution

@hod-alpert hod-alpert requested a review from Itay4 September 15, 2020 14:46
@hod-alpert hod-alpert marked this pull request as ready for review September 15, 2020 14:51
Itay4
Itay4 reviewed Sep 15, 2020
View reviewed changes
Itay4
10000 Itay4 reviewed Sep 15, 2020
View reviewed changes
Itay4
Itay4 reviewed Sep 15, 2020
View reviewed changes
Itay4
Itay4 reviewed Sep 15, 2020
View reviewed changes
Itay4
Itay4 reviewed Sep 15, 2020
View reviewed changes
Itay4
Itay4 reviewed Sep 15, 2020
View reviewed changes
Itay4
Itay4 reviewed Sep 15, 2020
View reviewed changes
Itay4
Itay4 reviewed Sep 15, 2020
View reviewed changes
Itay4
Itay4 reviewed Sep 15, 2020
View reviewed changes
Itay4
Itay4 reviewed Sep 15, 2020
View reviewed changes
@hod-alpert hod-alpert requested a review from Itay4 September 16, 2020 09:04
@hod-alpert hod-alpert force-pushed the hod/mitre_layout branch 2 times, most recently from 44cc4ea to e9db2d6 Compare September 21, 2020 08:06
@kirbles19
Copy link
Contributor

@hod-alpert Done.

@hod-alpert hod-alpert merged commit 64cac0b into master Sep 29, 2020
@hod-alpert hod-alpert deleted the hod/mitre_layout branch September 29, 2020 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Itay4 Itay4 Itay4 approved these changes

Assignees

@kirbles19 kirbles19

Labels
docs-approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hod-alpert @Itay4 @kirbles19 @jochman
0