10000 Nit on readDir entry mode by kevinkassimo · Pull Request #1326 · denoland/deno · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Nit on readDir entry mode #1326

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 12, 2018
Merged

Nit on readDir entry mode #1326

merged 1 commit into from
Dec 12, 2018

Conversation

kevinkassimo
Copy link
Contributor
@kevinkassimo kevinkassimo commented Dec 12, 2018 •
edited
Loading

Closes #1317

  • Make sure deno.readDir entries contains mode (I gave up with adding path/name for deno.stat)

ry
ry reviewed Dec 12, 2018
View reviewed changes
Copy link
Member
@ry ry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine, but it would be helpful if you split this into two commits.

ry
ry reviewed Dec 12, 2018
View reviewed changes
js/console.ts Outdated
// In cases e.g. Uint8Array.prototype
try {
for (const el of value) {
entries.push(config.entryHandler(el, ctx, level + 1, maxLevel));
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test for this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moved to another PR

@kevinkassimo kevinkassimo changed the title Nit on console and readDir entry mode Nit on readDir entry mode Dec 12, 2018
ry
ry approved these changes Dec 12, 2018
View reviewed changes
Copy link
Member
@ry ry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks!

@ry ry merged commit 585de35 into denoland:master Dec 12, 2018
ry added a commit to ry/deno that referenced this pull request Dec 14, 2018
@ry
v0.2.3
f815090 
- console.assert should not throw error (denoland#1335)
- Support more modes in deno.open (denoland#1282, denoland#1336)
- Simplify code fetch logic (denoland#1322)
- readDir entry mode (denoland#1326)
- Use stderr for exceptions (denoland#1303)
- console.log formatting improvements (denoland#1327, denoland#1299)
- Expose TooLarge error code for buffers (denoland#1298)
@ry ry mentioned this pull request Dec 14, 2018
Merged
ry added a commit that referenced this pull request Dec 14, 2018
@ry
v0.2.3
c69d2f5 
- console.assert should not throw error (#1335)
- Support more modes in deno.open (#1282, #1336)
- Simplify code fetch logic (#1322)
- readDir entry mode (#1326)
- Use stderr for exceptions (#1303)
- console.log formatting improvements (#1327, #1299)
- Expose TooLarge error code for buffers (#1298)
@kevinkassimo kevinkassimo deleted the nit/1 branch December 27, 2019 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ry ry ry approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kevinkassimo @ry
0