Implement console.trace() #2780
Conversation
js/console.ts
Outdated
| const message = stringifyArgs(args, { | ||
| indentLevel: this.indentLevel, | ||
| collapsedAt: this.collapsedAt, | ||
| noTrailingNewline: true |
There was a problem hiding this comment.
Why is noTrailingNewline necessary?
There was a problem hiding this comment.
It is just that without this settings there will be a newline appended to message by stringifyArgs and thus leaving a blank line between message and trace on printing err.stack.
(There is definitely no specification saying this is not allow, just I feel it would be kind of ugly...)
There was a problem hiding this comment.
I appreciate it being formatted as you have it.
Rather, I'm suggesting that instead of adding noTrailingNewline, you make it so stringifyArgs doesn't add a trailing \n and lift that into the existing callers.
There was a problem hiding this comment.
I reviewed the structure of console.ts and realized that there are some complexity introduced by console.groupCollapsed(). I believe the original intention of introducing it was to allow synchronous write to stdout, which is available now since we added File::writeSync.
Technically console.groupCollapsed() behavior we have is non-standard, as the definition of being collapsed refers to something like a dropdown. Node simply aliases groupCollapsed to group
If we were to make console.groupCollapsed to alias console.group, then things could simplify quite a bit.
… out of stringifyArgs, fix console.dir, add tests, and fix a repl log quirk For repl logging quirks, I believe we should not indent repl logging. If we really want such indentation, we probably also want to indent "> " prompts.
Noticed that we have never implemented this.
https://console.spec.whatwg.org/#trace